Move Quest core logic into its own class. #2807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheosRee
force-pushed
the
extract-quest-logic
branch
from
9202a13
to
a1018b5
Compare
TheosRee
force-pushed
the
extract-quest-logic
branch
2 times, most recently
from
7ebd235
to
34602a8
Compare
|
It uses currently the same logger as the BetonQuest plugin class so there is also no difference in logging. |
…st canceller out of plugin class
move null check out of ConversationData
TheosRee
force-pushed
the
extract-quest-logic
branch
from
34602a8
to
7199f38
Compare
Wolf2323
reviewed
May 29, 2024
src/main/java/org/betonquest/betonquest/conversation/ConversationData.java
Outdated
Show resolved
Hide resolved
src/main/java/org/betonquest/betonquest/quest/registry/QuestRegistry.java
Outdated
Show resolved
Hide resolved
…w we got the result: the plural of canceler is cancelers, not just canceler
Wolf2323
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move storage and usage of Conditions, Events, Objectives and Variables to new class.
Reduce the size of the plugin class.
Feel free to suggest another class and package name.
Related Issues
Closes #XXXX
Requirements
Reviewer's checklist
Did the contributor...
Check if the build pipeline succeeded for this PR!