Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Quest core logic into its own class. #2807

Merged
merged 20 commits into from
Jun 3, 2024
Merged

Move Quest core logic into its own class. #2807

merged 20 commits into from
Jun 3, 2024

Commits on May 28, 2024

  1. move conditions, events, objectives, variables, conversations and que… 

    …st canceller out of plugin class
    @TheosRee
    TheosRee committed May 28, 2024
    Configuration menu
    Copy the full SHA
    e94b211 View commit details
    Browse the repository at this point in the history

  2. move condition logic

    @TheosRee
    TheosRee committed May 28, 2024
    Configuration menu
    Copy the full SHA
    e70af13 View commit details
    Browse the repository at this point in the history

  3. extract QuestProcessor

    @TheosRee
    TheosRee committed May 28, 2024
    Configuration menu
    Copy the full SHA
    f1c3b09 View commit details
    Browse the repository at this point in the history

  4. PMD

    @TheosRee
    TheosRee committed May 28, 2024
    Configuration menu
    Copy the full SHA
    2c30197 View commit details
    Browse the repository at this point in the history

  5. extract event logic

    @TheosRee
    TheosRee committed May 28, 2024
    Configuration menu
    Copy the full SHA
    5fc2660 View commit details
    Browse the repository at this point in the history

  6. extract objective logic

    @TheosRee
    TheosRee committed May 28, 2024
    Configuration menu
    Copy the full SHA
    22b3b07 View commit details
    Browse the repository at this point in the history

  7. extract variable logic

    @TheosRee
    TheosRee committed May 28, 2024
    Configuration menu
    Copy the full SHA
    27cff33 View commit details
    Browse the repository at this point in the history

  8. extract quest canceller

    @TheosRee
    TheosRee committed May 28, 2024
    Configuration menu
    Copy the full SHA
    448c823 View commit details
    Browse the repository at this point in the history

  9. extract conversation data logic 

    move null check out of ConversationData
    @TheosRee
    TheosRee committed May 28, 2024
    Configuration menu
    Copy the full SHA
    74e872a View commit details
    Browse the repository at this point in the history

  10. move the now leftover #loadData into QuestRegistry

    @TheosRee
    TheosRee committed May 28, 2024
    Configuration menu
    Copy the full SHA
    abc48b5 View commit details
    Browse the repository at this point in the history

  11. move the QuestRegistry and processors into sub-packages

    @TheosRee
    TheosRee committed May 28, 2024
    Configuration menu
    Copy the full SHA
    7199f38 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2024

  1. Review changes

    @TheosRee
    TheosRee committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    f193641 View commit details
    Browse the repository at this point in the history

  2. move creation of EventScheduling, remove code comments

    @TheosRee
    TheosRee committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    3e567b5 View commit details
    Browse the repository at this point in the history

  3. flip generic types in QuestProcessor to match internal Map structure

    @TheosRee
    TheosRee committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    c1c8228 View commit details
    Browse the repository at this point in the history

  4. use new logger per class

    @TheosRee
    TheosRee committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    5b426ba View commit details
    Browse the repository at this point in the history

  5. add TypedQuestProcessor

    @TheosRee
    TheosRee committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    a315158 View commit details
    Browse the repository at this point in the history

  6. move static resolveVariables method back to BetonQuest.java

    @TheosRee
    TheosRee committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    8cc537a View commit details
    Browse the repository at this point in the history

  7. remove now unnecessary method identifications

    @TheosRee
    TheosRee committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    0a898c0 View commit details
    Browse the repository at this point in the history

  8. remove now unnecessary method identifications and MetricSupplying.java

    @TheosRee
    TheosRee committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    ca8209f View commit details
    Browse the repository at this point in the history

  9. after a long discussion and some advice from persons I don't even kno… 

    …w we got the result: the plural of canceler is cancelers, not just canceler
    @TheosRee
    TheosRee committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    25b7fd9 View commit details
    Browse the repository at this point in the history