Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't use $current-form more than once in a custom repl command snippet #1301

Closed
colinkahn opened this issue Sep 25, 2021 · 4 comments
Closed
Labels
bug Something isn't working repl

Comments

@colinkahn
Copy link

There is an issue if you use $current-form twice in a snippet, like so:

   "calva.customREPLCommandSnippets": [
     {
         "name": "foo",
         "snippet": "(vector $current-form (quote $current-form))"
     }
     ]

This will output for the expression (do {:foo :bar}):

 (vector (do {:foo :bar}) (quote $current-form))
 [{:foo :bar} $current-form]
@bpringe bpringe added repl bug Something isn't working labels Sep 26, 2021
@bpringe bpringe assigned PEZ and unassigned PEZ Sep 26, 2021
@PEZ
Copy link
Collaborator

PEZ commented Sep 26, 2021

Thanks for reporting!

PEZ added a commit that referenced this issue Sep 26, 2021
@PEZ PEZ mentioned this issue Sep 26, 2021
11 tasks
@PEZ
Copy link
Collaborator

PEZ commented Sep 26, 2021

Not sure why this isn't auto-closed, but anyway, @colinkahn, this should be fixed in latest release, 2.0.212.

@colinkahn
Copy link
Author

Thanks!

@bpringe
Copy link
Member

bpringe commented Sep 27, 2021

Not sure why this isn't auto-closed

Just FYI, it may be because your commit used "fixing" instead of something like "fixes." I'm not sure if "fixing" is one of the words that triggers the closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working repl
Projects
None yet
Development

No branches or pull requests

3 participants