Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structural editing should treat reader tags as part of the tagged form #570

Closed
PEZ opened this issue Mar 1, 2020 · 0 comments
Closed

Structural editing should treat reader tags as part of the tagged form #570

PEZ opened this issue Mar 1, 2020 · 0 comments

Comments

@PEZ
Copy link
Collaborator

PEZ commented Mar 1, 2020

Calva treats reader tags, like #uuid in #uuid "1e4cfe00-ddb6-4c88-8d4e-c6064149e240", as a separate form. This makes structural editing, rainbow highlighting and ignore highlighting all do the wrong thing. And at a deeper level it makes for crazy workaround hacks to navigate the code correctly when implementing various features.

Things should be rainbow highlighted, and navigated more like this:

data-reader-token-cursor

Ignore highlight should work like this:

image

PEZ added a commit that referenced this issue Mar 1, 2020
@PEZ PEZ closed this as completed in 3301e0a Mar 1, 2020
PEZ added a commit that referenced this issue Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant