Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two CLJ REPL Windows open on connect when afterCLJReplJackInCodeis used #593

Closed
PEZ opened this issue Mar 21, 2020 · 0 comments
Closed

Two CLJ REPL Windows open on connect when afterCLJReplJackInCodeis used #593

PEZ opened this issue Mar 21, 2020 · 0 comments
Labels
bug Something isn't working connect

Comments

@PEZ
Copy link
Collaborator

PEZ commented Mar 21, 2020

The afterCLJReplJackInCode option of the Custom Connect Sequences are run in the REPL Window, in order for it to be visible and its results and printing side effects to be easy to find.

However, if the user has the calva.openREPLWindowOnConnect setting enabled, it will also open the CLJ window, and right now it results in that two window are opened:

  • One that doesn't get a working prompt
  • The other is where the afterCLJReplJackInCode is evaluated
    • Here the prompt works, however..
  • Closing the first window will make the working prompt stop working

The fix here is to make sure only one window is opened per REPL session, and that this window is used for the custom after-connect commands.

@PEZ PEZ added bug Something isn't working repl-window connect labels Mar 21, 2020
PEZ added a commit that referenced this issue Mar 21, 2020
@PEZ PEZ mentioned this issue Mar 21, 2020
19 tasks
@PEZ PEZ closed this as completed in 07f1e84 Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working connect
Projects
None yet
Development

No branches or pull requests

1 participant