Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calva's ESC keybinding overrides VS Code's (useful) default #740

Closed
crispinb opened this issue Aug 10, 2020 · 1 comment
Closed

Calva's ESC keybinding overrides VS Code's (useful) default #740

crispinb opened this issue Aug 10, 2020 · 1 comment

Comments

@crispinb
Copy link
Contributor

The default keybinding for ESC (editor.action.cancelSelectionAnchor) is useful for quickly dismissing a text selection without having to reach for the arrow keys.

Calva's use of ESC (to clear evaluation results) overrides this, and it doesn't seem to be possible to distinguish the 2 bindings with a 'when' clause. So the user must choose between the default and Calva's ESC binding.

Ideally, it would be possible to dismiss both text selections, and evaluation results, with the same key.

@PEZ
Copy link
Collaborator

PEZ commented Aug 10, 2020

This should be changed in Calva (PR welcome).

Meanwhile you can fix it for your own setup by changing the when clause for Calva's ESC key binding to:

editorTextFocus && !editorHasMultipleSelections && !editorHasSelection && !editorReadOnly && !hasOtherSuggestions && !parameterHintsVisible && !selectionAnchorSet && !suggestWidgetVisible && editorLangId == 'clojure'

crispinb added a commit to crispinb/calva that referenced this issue Aug 11, 2020
- as per [Calva's ESC keybinding overrides VS Code's (useful) default](BetterThanTomorrow#740)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants