Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Goto definition not working for dependent libs since 2.0.137 #897

Closed
fonghou opened this issue Dec 28, 2020 · 5 comments
Closed

Goto definition not working for dependent libs since 2.0.137 #897

fonghou opened this issue Dec 28, 2020 · 5 comments
Labels
bug Something isn't working upstream

Comments

@fonghou
Copy link

fonghou commented Dec 28, 2020

Like clojure-lsp integration. Two things I noticed:

  1. auto completion (goto/peek definition) does not work for namespaces from dependent libs. I remember standalone clojure-lsp supports these. Are they disabled in calva version?

  2. After connecting to nrepl, goto/peek definition still does not work for external dependent libs. They used to work in 2.0.136.

Thanks!
@PEZ
Copy link
Collaborator

PEZ commented Dec 28, 2020

Hello. Are you on Windows perhaps?

PEZ added a commit that referenced this issue Dec 28, 2020
@PEZ
Use symbol definitions from cider-nrepl before lsp
6afee23 
Addresses #897
@PEZ PEZ mentioned this issue Dec 28, 2020
Merged
20 tasks
@fonghou
Copy link
Author

fonghou commented Dec 28, 2020

Hi, yes i am on windows.

@PEZ
Copy link
Collaborator

PEZ commented Dec 28, 2020

It might be a problem upstream. clojure-lsp/clojure-lsp#223

We are going to release a workaround so that we use nrepl definitions when they are available. Later today.

@bpringe bpringe added bug Something isn't working upstream labels Dec 28, 2020
@PEZ
Copy link
Collaborator

PEZ commented Jan 3, 2021

This should be working now, right?

@bpringe bpringe closed this as completed Jan 4, 2021
@bpringe
Copy link
Member

bpringe commented Jan 4, 2021

Yes, should be. If anyone sees otherwise, please let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working upstream
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@PEZ @bpringe @fonghou