Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve clojure-lsp status bar feedback #1454

Merged

Conversation

ericdallo
Copy link
Contributor

@ericdallo ericdallo commented Jan 8, 2022

What has Changed?

  • Reduce existing clojure-lsp status bar item to be less noisy and use official clojure-lsp live feedback, which presents which step clojure-lsp is doing during startup:
    image
  • VSCode does not allow changing the $(sync~spin) clojure-lsp: string, unfortunately. I tried to make the best UX possible with what vscode provides.
  • VSCode doesn't support showing the percentage for some reason.

This make feedback much similar to how Emacs feedback works:
image

My Calva PR Checklist

I have:

  • Read How to Contribute.
  • Directed this pull request at the dev branch. (Or have specific reasons to target some other branch.)
  • Made sure I have changed the PR base branch, so that it is not published. (Sorry for the nagging.)
  • Updated the [Unreleased] entry in CHANGELOG.md, linking the issue(s) that the PR is addressing.
  • Figured if anything about the fix warrants tests on Mac/Linux/Windows/Remote/Whatever, and either tested it there if so, or mentioned it in the PR.
    - [ ] Added to or updated docs in this branch, if appropriate
    - [ ] Tested the VSIX built from the PR (so, after you've submitted the PR). You'll find the artifacts by clicking Show all checks in the CI section of the PR page, and then Details on the ci/circleci: build test.
    • Tested the particular change
    • Figured if the change might have some side effects and tested those as well.
      - [ ] Smoke tested the extension as such.
      - [ ] Referenced the issue I am fixing/addressing in a commit message for the pull request.
      - [ ] If I am fixing the issue, I have used GitHub's fixes/closes syntax
      - [ ] If I am fixing just part of the issue, I have just referenced it w/o any of the "fixes” keywords.
      - [ ] Created the issue I am fixing/addressing, if it was not present.

Ping @PEZ, @bpringe

@bpringe
Copy link
Member

bpringe commented Jan 8, 2022

Awesome! So how does that right side message get set? This:
image

I only see this being set in the code changes:
image

@bpringe bpringe merged commit 44a17b5 into BetterThanTomorrow:dev Jan 8, 2022
@ericdallo
Copy link
Contributor Author

@bpringe it's automatically from LSP, clojure-lsl already send notifications with the progress, the vscode LSP plugin just render that

@ericdallo ericdallo deleted the improve-lsp-status-bar-item branch January 8, 2022 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants