Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1475 prompt unicode characters #1485

Merged
merged 2 commits into from
Jan 18, 2022
Merged

1475 prompt unicode characters #1485

merged 2 commits into from
Jan 18, 2022

Conversation

PEZ
Copy link
Collaborator

@PEZ PEZ commented Jan 18, 2022

What has Changed?

I've added default settings in the [clojure] scope for allowing the unicode characters that we use in the REPL prompt.

For now. I think we should entertain the option to instead render our prompt w/o unicode characters.

Fixes #1475

My Calva PR Checklist

I have:

  • Read How to Contribute.
  • Directed this pull request at the dev branch. (Or have specific reasons to target some other branch.)
  • Made sure I have changed the PR base branch, so that it is not published. (Sorry for the nagging.)
  • Updated the [Unreleased] entry in CHANGELOG.md, linking the issue(s) that the PR is addressing.
  • Figured if anything about the fix warrants tests on Mac/Linux/Windows/Remote/Whatever, and either tested it there if so, or mentioned it in the PR.
  • [ ] Added to or updated docs in this branch, if appropriate
  • Tests
    • Tested the particular change
    • Figured if the change might have some side effects and tested those as well.
    • Smoke tested the extension as such.
    • Tested the VSIX built from the PR (so, after you've submitted the PR). You'll find the artifacts by clicking Show all checks in the CI section of the PR page, and then Details on the ci/circleci: build test.
  • Referenced the issue I am fixing/addressing in a commit message for the pull request.
    • If I am fixing the issue, I have used GitHub's fixes/closes syntax
    • If I am fixing just part of the issue, I have just referenced it w/o any of the "fixes” keywords.
  • Created the issue I am fixing/addressing, if it was not present.

Ping @PEZ, @bpringe

@PEZ PEZ linked an issue Jan 18, 2022 that may be closed by this pull request
@PEZ PEZ merged commit e657c78 into dev Jan 18, 2022
@PEZ PEZ deleted the 1475-prompt-unicode-characters branch January 18, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VS Code highlights characters in the output/REPL window prompt
1 participant