Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initial integration tests #1518

Merged
merged 13 commits into from Feb 16, 2022
Merged

initial integration tests #1518

merged 13 commits into from Feb 16, 2022

Conversation

Cyrik
Copy link
Member

@Cyrik Cyrik commented Feb 6, 2022 •
edited

What has Changed?

  • added integration for nrepl start
    • loads a clj file
    • starts a deps.edn nrepl
    • evals the file
    • checks for calva-output
  • switches docker image to one that has Clojure installed

We can use this as a base for more integration tests, but it's a good smoke test for now.

My Calva PR Checklist

I have:

  • Read How to Contribute.
  • Directed this pull request at the dev branch. (Or have specific reasons to target some other branch.)
  • Made sure I have changed the PR base branch, so that it is not published. (Sorry for the nagging.)
  • Updated the [Unreleased] entry in CHANGELOG.md, linking the issue(s) that the PR is addressing.
  • Figured if anything about the fix warrants tests on Mac/Linux/Windows/Remote/Whatever, and either tested it there if so, or mentioned it in the PR.
  • Added to or updated docs in this branch, if appropriate
  • Tests
    • Tested the particular change
    • Figured if the change might have some side effects and tested those as well.
    • Smoke tested the extension as such.
    • Tested the VSIX built from the PR (so, after you've submitted the PR). You'll find the artifacts by clicking Show all checks in the CI section of the PR page, and then Details on the ci/circleci: build test.
  • Referenced the issue I am fixing/addressing in a commit message for the pull request.
    • If I am fixing the issue, I have used GitHub's fixes/closes syntax
    • If I am fixing just part of the issue, I have just referenced it w/o any of the "fixes” keywords.
  • Created the issue I am fixing/addressing, if it was not present.

Ping @PEZ, @bpringe

@Cyrik Cyrik marked this pull request as draft February 6, 2022 13:37
@Cyrik
Copy link
Member Author

Cyrik commented Feb 6, 2022

still very much playing around, but wanted to share my initial working version

@Cyrik Cyrik marked this pull request as ready for review February 13, 2022 23:53
@Cyrik Cyrik requested a review from PEZ February 14, 2022 00:00
PEZ
PEZ reviewed Feb 16, 2022
View reviewed changes
.vscode/launch.json Outdated
"IS_DEBUG": "true",
"IS_DEBUG": "true",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks a bit odd?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah whoops, that was an accident, good catch.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it strange that it passed the prettier test step, @corasaurus-hex ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prettier just formats typescript and javascript right now. https://github.com/BetterThanTomorrow/calva/blob/published/package.json#L2584-L2585

We could expand it to also format json and other file types, though!

PEZ
PEZ requested changes Feb 16, 2022
View reviewed changes
Copy link
Collaborator

@PEZ PEZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wonderful!!

The name of the test is the only thing I'd like fixed before merging.

src/extension-test/integration/suite/extension-test.ts Outdated
Comment on lines 44 to 45
test('connect to repl', async function () {
console.log('connect to repl');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably should be 'start repl and connect (jack-in)' as connect has a the special meaning in Calva of assuming the REPL is already started.

@Cyrik Cyrik requested a review from PEZ February 16, 2022 15:51
PEZ
PEZ approved these changes Feb 16, 2022
View reviewed changes
Copy link
Collaborator

@PEZ PEZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 ❤️ 🎉

@PEZ PEZ merged commit 1d860e9 into BetterThanTomorrow:dev Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corasaurus-hex corasaurus-hex corasaurus-hex left review comments

@PEZ PEZ PEZ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Cyrik @corasaurus-hex @PEZ