New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test ns query under var-query field #1983
Conversation
Thanks for contributing! 🙏 ❤️ By the wording in the PR, it seems like you have found the right place to fix it. Haven't had a look yet. Will tomorrow! Prepping for this event right now: https://www.meetup.com/london-clojurians/events/286030325/ 😄 |
@PEZ I'm not sure why that build-test workflow fails while packaging the vsix.
|
That is a very, very strange, and worrying, error. I'll have a look later today. |
I find this issue, which seems to have cause a ruckus in the Webpack community: It is many, many pages of comments. Seems like the conclusion is to upgrade to Webpack 5. Which sucks a bit for us, because that is what we are using! But anyway, now I am not as scared by this error. I'm sure we'll at least find a workaround with some sensible amount of work. |
I've reproduced the error in a separate branch. Let's see if I can figure out a way to fix it. |
OK, sorry that your PR got a bit messy with the Webpack business, @deadeyejoe. But now we have a workaround/maybe-fix on |
To fix issue 1981. Runnning a single test would result in every test in every namespace being run. This was because the test var query was being spread into the nrepl payload, rather than being passed as 'var-query'. Looks to have been introduced by commit f7844f3.
Removed reference to polylith as this affects all project types
Fingers crossed! |
Thanks again, @deadeyejoe! |
Closes #1981.
What has changed?
Running a single test would result in every test in every namespace being run. This was because the test var query was being spread into the nrepl payload, rather than being passed as 'var-query'.
Looks to have been introduced by commit f7844f3.
My Calva PR Checklist
If this PR involves only documentation changes, I have:
published
branch.If this PR involves code changes, I have:
dev
branch. (Or have specific reasons to target some other branch.)published
. (Sorry for the nagging.)[Unreleased]
entry inCHANGELOG.md
, linking the issue(s) that the PR is addressing.ci/circleci: build
test.npm run prettier-format
)npm run eslint
before creating your PR, or runnpm run eslint-watch
to eslint as you go).Ping @PEZ, @bpringe, @corasaurus-hex, @Cyrik