Don't block on snippet evaluation #2013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool! Many thanks for your quality focus! I will have a look later tonight, I hope. |
If a snippet is evaluated with runCustomREPLCommand and it blocks (due to a bug or some such) then the editor almost completely deadlocks. This commit changes the command handler for `runCustomREPLCommand` to not block on snippet evaluation. Fixes BetterThanTomorrow#2012
julienvincent
force-pushed
the
fix/blocking-snippet-eval
branch
from
2b2b0ad
to
8a8f8c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a snippet is evaluated with runCustomREPLCommand and it blocks (due to a bug or some such) then the editor almost completely deadlocks.
This commit changes the command handler for
runCustomREPLCommandto not block on snippet evaluation.Fixes #2012