Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clojure-lsp regressions from #2020 #2046

Merged
merged 8 commits into from Feb 1, 2023

Commits on Jan 30, 2023

  1. Only auto-start clojure-lsp in valid projects

    When the `"when-workspace-opened-use-workspace-root"` setting is enabled
    the clojure-lsp is started in _all_ workspace roots open instead of only
    valid clojure project roots.
    
    This commit reworks this behaviour to first check if the workspace root
    is a valid Clojure project before attempting to auto-start the lsp
    server.
    
    Addresses BetterThanTomorrow#2041
    julienvincent committed Jan 30, 2023
    Copy the full SHA
    a1a6d28 View commit details
    Browse the repository at this point in the history
  2. Ensure clojure-lsp commands are still registered

    This resolves a regression from BetterThanTomorrow#2020 which prevents certain vscode
    operations such as organise-imports and add-missing-import from
    functioning correctly.
    
    This was a result of disabling the automatic command registrations being
    performed by the lsp client. Originally it was assumed that these
    commands were unused, however they are used internally by vscode to
    handle their native organise-imports and related operations.
    
    This is now fixed by manually registering the missing commands with the
    added functionality of multi-client support.
    
    Addresses BetterThanTomorrow#2041
    Fixes BetterThanTomorrow#2040
    julienvincent committed Jan 30, 2023
    Copy the full SHA
    f80217a View commit details
    Browse the repository at this point in the history
  3. Simplify project selection menus

    The clojure-lsp refactor project in BetterThanTomorrow#2020 reworked the way the project
    picker menus work, adding additional information on a second line
    indicating which files contributed to a folder being picked as a valid
    clojure project.
    
    This turned out significant hurt the UX experience in workspaces with
    many clojure projects.
    
    This commit removes the additional information from the picker menus,
    shrinking the list items to a single line.
    
    Some other smaller changes included:
    
    - Projects are now grouped by their workspace root which should help
      make it easier to sort through the list visually.
    - Project folders are now sorted within their groups to make the list
      more deterministic.
    - Project folders show the path relative to the workspace root instead
      of the absolute path. This should help make scanning the list easier
      by removing unnecessary/duplicate information.
    
    Addresses BetterThanTomorrow#2041
    Closes BetterThanTomorrow#2043
    julienvincent committed Jan 30, 2023
    Copy the full SHA
    65eea81 View commit details
    Browse the repository at this point in the history
  4. Update CHANGELOG

    julienvincent committed Jan 30, 2023
    Copy the full SHA
    2c4405e View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    13d539f View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2023

  1. Update comment wording

    Co-authored-by: Brandon Ringe <12722744+bpringe@users.noreply.github.com>
    julienvincent and bpringe committed Feb 1, 2023
    Copy the full SHA
    c6e3a33 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    c241bbe View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    29131d4 View commit details
    Browse the repository at this point in the history