Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hiccup fixes #2 #2131

Merged
merged 2 commits into from
Mar 25, 2023
Merged

Hiccup fixes #2 #2131

merged 2 commits into from
Mar 25, 2023

Conversation

PEZ
Copy link
Collaborator

@PEZ PEZ commented Mar 25, 2023

What has changed?

It turns out that when VS Code calls commands from the Edit and editor context menu, it passes on an args map with an options map in it, just like we do for the hiccup commands. So our check for an options map in the args wasn't sufficient to tell if the user had provided the hiccup options. We are now checking if the options provided to the commands has any hiccup options.

I also updated the keyboard shortcuts examples a bit.

My Calva PR Checklist

I have:

  • Read How to Contribute.
  • Directed this pull request at the dev branch. (Or have specific reasons to target some other branch.)
  • Made sure I have changed the PR base branch, so that it is not published. (Sorry for the nagging.)
  • Updated the [Unreleased] entry in CHANGELOG.md, linking the issue(s) that the PR is addressing.
  • Figured if anything about the fix warrants tests on Mac/Linux/Windows/Remote/Whatever, and either tested it there if so, or mentioned it in the PR.
  • Added to or updated docs in this branch, if appropriate
  • Tests
    • Tested the particular change
    • Figured if the change might have some side effects and tested those as well.
  • Referenced the issue I am fixing/addressing in a commit message for the pull request.
  • Created the issue I am fixing/addressing, if it was not present.
  • Formatted all JavaScript and TypeScript code that was changed. (use the prettier extension or run npm run prettier-format)
  • Confirmed that there are no linter warnings or errors (use the eslint extension, run npm run eslint before creating your PR, or run npm run eslint-watch to eslint as you go).

Ping @PEZ, @bpringe, @corasaurus-hex, @Cyrik

@PEZ PEZ requested a review from bpringe March 25, 2023 16:43
@PEZ PEZ merged commit 4d4bb91 into dev Mar 25, 2023
@PEZ PEZ deleted the 2130-copy-hiccup-fixes branch March 25, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant