Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make jack-in deps versions configurable #899

Merged
merged 2 commits into from
Dec 28, 2020
Merged

Make jack-in deps versions configurable #899

merged 2 commits into from
Dec 28, 2020

Conversation

PEZ
Copy link
Collaborator

@PEZ PEZ commented Dec 28, 2020

What has Changed?

We make the jack-in deps configurable and also bump them all to latest versions with the provided default settings.

Fixes #896
Closes #852

My Calva PR Checklist

I have:

  • Read How to Contribute.
  • Directed this pull request at the dev branch. (Or have specific reasons to target some other branch.)
  • Made sure I have changed the default PR base branch, so that it is not master. (Sorry for the nagging.)
  • Updated the [Unreleased] entry in CHANGELOG.md, linking the issue(s) that the PR is addressing.
  • Figured if anything about the fix warrants tests on Mac/Linux/Windows/Remote/Whatever, and either tested it there if so, or mentioned it in the PR.
  • Tested the VSIX built from the PR (so, after you've submitted the PR). You'll find the artifacts by clicking Show all checks in the CI section of the PR page, and then Details on the ci/circleci: build test. NB: There is a CircleCI bug that makes the Artifacts hard to find. Please see this issue for workarounds.
    • Tested the particular change
    • Figured if the change might have some side effects and tested those as well.
    • Smoke tested the extension as such.
  • Referenced the issue I am fixing/addressing in a commit message for the pull request.
  • Added to or updated docs in this branch, if appropriate

The Calva Team PR Checklist:

Before merging we (at least one of us) have:

  • Made sure the PR is directed at the dev branch (unless reasons).
  • Figured if anything about the fix warrants tests on Mac/Linux/Windows/Remote/Whatever, and tested it there if so.
  • Read the source changes.
  • Given feedback and guidance on source changes, if needed. (Please consider noting extra nice stuff as well.)
  • Tested the VSIX built from the PR (well, if this is a PR that changes the source code.)
    • Tested the particular change
    • Figured if the change might have some side effects and tested those as well.
    • Smoke tested the extension as such.
  • If need be, had a chat within the team about particular changes.

Ping @PEZ, @kstehn, @cfehse, @bpringe

@PEZ
Copy link
Collaborator Author

PEZ commented Dec 28, 2020

We should probably update the docs too.

@bpringe
Copy link
Member

bpringe commented Dec 28, 2020

Closes #852 as well. I don't think this comment will suffice to cause the auto closure.

@bpringe
Copy link
Member

bpringe commented Dec 28, 2020

I tested the VSIX as well.

@bpringe
Copy link
Member

bpringe commented Dec 28, 2020

Great idea making these configurable!

@PEZ
Copy link
Collaborator Author

PEZ commented Dec 28, 2020

I think you can edit the PR description, @bpringe . That might auto-close the issue.

@PEZ
Copy link
Collaborator Author

PEZ commented Dec 28, 2020

Added the docs, @bpringe . This is good to go, me thinks, especially since you've tested it too. However, family calls here. If you find some time, please merge and release.

@PEZ PEZ merged commit 2d1ee62 into dev Dec 28, 2020
@PEZ PEZ deleted the 896-bump-jack-in-deps branch December 28, 2020 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants