Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add default localizations #68

Merged
merged 2 commits into from
Jul 20, 2022
Merged

fix: add default localizations #68

merged 2 commits into from
Jul 20, 2022

Conversation

Kirpal
Copy link
Collaborator

@Kirpal Kirpal commented Jul 18, 2022

Description

I added default widgets/material/cupertino localizations so the user doesn't need to manually add them, but they can if they want to.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@codecov
Copy link

codecov bot commented Jul 18, 2022

Codecov Report

Merging #68 (e43b28a) into main (f9f57c9) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #68   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines          518       538   +20     
=========================================
+ Hits           518       538   +20     
Impacted Files Coverage Δ
lib/src/golden_test_adapter.dart 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9f57c9...e43b28a. Read the comment docs.

@marcossevilla marcossevilla merged commit 22305a1 into main Jul 20, 2022
@marcossevilla marcossevilla deleted the fix/l10n branch July 20, 2022 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants