Allow test_track_visitor_id to be passed via headers #29
Conversation
|
Needs somebody from @jmileham, @samandmoore, and @aburgel to claim domain review. Use the shovel operator to claim, e.g.:
|
I think it should only be passed back when it changes, probably? Like a |
app/models/test_track/visitor.rb
Outdated
| @@ -98,6 +98,10 @@ def loaded? | |||
| !offline? && @remote_visitor.present? | |||
| end | |||
|
|
|||
| def id_changed? | |||
There was a problem hiding this comment.
Tried to follow rails naming conventions, but maybe this hides what this actually represents, the fact that the visitor id was overridden by the remote visitor?
There was a problem hiding this comment.
Yeah, I think you might want to go with a special name here. Remote won't have as much meaning to a browser of the controller mixin because to them the remote in mind is the client of the controller, not the upstream TT server, so some name that captures that the TT server changed our identity would be hot.
There was a problem hiding this comment.
id_overridden_by_existing_visitor??
|
bump |
| subject.log_in!("identifier_type", "value") | ||
| end | ||
|
|
||
| expect(controller.response.headers['X-Set-TT-Visitor-ID']).to eq(nil) |
|
<< domain tafn. Just come up with an awesome name and this is looking great. |
|
@betterzega needs to incorporate feedback from @jmileham. Bump when done. |
|
that'll work. it's a long enough name that it doesn't give you unwarranted confidence that you know what it's doing. domain lgtm! |
|
Ready to merge! 💫 🔩 👯 |
betterzega
force-pushed
the
zega/use-header-for-test-track-visitor-id
branch
from
df57691
to
1bc57d4
Compare
/domain @jmileham @samandmoore @aburgel
From our conversation in the test_track channel, allowing the session to be read from the request header.
Still need to write back the test track visitor id in the response header. Should this only be passed back when the request has the TT visitor id in the header, or should it always be passed back?
Still need to do a proper integration test.