Raise error for duplicate stubbed urls #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nting to the same url
|
nanda? |
|
Needs somebody from @Betterment/webvalve-core to claim domain review Use the shovel operator to claim, e.g.:
|
effron
changed the title
|
Looks great. Thanks! <<domainlgtm Closes #39 Will merge and release in the next few days |
|
Approved! 💫 💰 🎇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #39
/domain @Betterment/webvalve-core
/no-platform
Raise an error if two different WebValve fake services are configured to intercept traffic for the same URL. Hopefully, this makes it easier to discover this kind of configuration bug.