Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geometry Nodes - Mix Color node is added back to the Color category - add to Add Shelf #3251

Closed
Draise14 opened this issue Sep 27, 2022 · 7 comments
Labels
0 - task A normal development task Known Issue We know about it, but cannot fix it

Comments

@Draise14
Copy link
Collaborator

bforartists_Qpu8hOus0d

They added the same Mix Color node with a different default to the Color Category in Geometry Nodes. So we should update the Add Shelf. The Utility Mix node defaults to Float. Mix Color defaults do Color.

@Draise14 Draise14 added the 0 - task A normal development task label Sep 27, 2022
@ReinerBforartists
Copy link
Contributor

They had one job ... ^^

@Draise14
Copy link
Collaborator Author

Yeah.. they merged the nodes, then they split it again... jeesus christ.

@ReinerBforartists ReinerBforartists self-assigned this Oct 7, 2022
@ReinerBforartists
Copy link
Contributor

No icon creation involved, let's tackle it

@ReinerBforartists
Copy link
Contributor

This task is mission impossible. What the heck. From the add menu it works. From the sidebar it is forbidden ...

Either way, postponing for after 3.3.1.

impossible
shadernodetree

@ReinerBforartists ReinerBforartists added the 5 - Postponed Still in the list, but will be done at a later point label Oct 8, 2022
@ReinerBforartists ReinerBforartists removed their assignment Oct 8, 2022
@ReinerBforartists ReinerBforartists removed the 5 - Postponed Still in the list, but will be done at a later point label Oct 11, 2022
@ReinerBforartists
Copy link
Contributor

ReinerBforartists commented Nov 7, 2022

I think the cause here is that this particular node has settings.

Normal operator: bpy.ops.node.add_node(type="ShaderNodeMixRGB", use_transform=True)

This particular operator: bpy.ops.node.add_node(type="ShaderNodeMix", use_transform=True, settings=[{"name":"data_type", "value":"'RGBA'"}])

I am having a hard time though to pass these settings to the python operator . It refuses to work. I tried everything i can think of now. Obviously i missed the working method ...

            props = col.operator("node.add_node", text=" Mix Color      ", icon = "COMBINE_COLOR")
            props.use_transform = True
            props.type = "ShaderNodeMix"
            props.settings = [{"name":"data_type", "value":"'RGBA'"}]

fails

Well, it creates the node. But cuts off the two at the end since it errors out at the settings. And it starts of course in Float mode ...

mixdilemma

The crazy part is, i just want to read it, so why does it moan that it is read only?

@iyadahmed , do you have an idea how to write the props settings here so that python doesn't fail at it?

ReinerBforartists pushed a commit that referenced this issue Nov 7, 2022
@ReinerBforartists
Copy link
Contributor

I simply can't see what i do wrong here.

I have now at least added (surprise, don't ask me why it initially failed) the prop. It starts with the wrong mode though. The Float mode. Since i cannot tell it to set it to RGBA mode.

As told, any help is highly appreciated.

fails

@ghost
Copy link

ghost commented Mar 1, 2023

Seems to be fixed in master, clicking the button though creates Mix Float instead of Mix Color,
also same issue with Mix Vector button

image

@ghost ghost closed this as completed Mar 1, 2023
@ReinerBforartists ReinerBforartists added the Known Issue We know about it, but cannot fix it label Mar 1, 2023
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - task A normal development task Known Issue We know about it, but cannot fix it
Projects
None yet
Development

No branches or pull requests

2 participants