Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add function setMapUrl to Router #32

Merged
merged 2 commits into from
Jan 27, 2022
Merged

add function setMapUrl to Router #32

merged 2 commits into from
Jan 27, 2022

Conversation

RazzibShakya
Copy link
Contributor

No description provided.

@RazzibShakya
Copy link
Contributor Author

@syaau is it enough for a defaultRouter to have a URL Mapper?

@syaau
Copy link
Contributor

syaau commented Jan 26, 2022

Url Mapper function along with the initial url

syaau
syaau reviewed Jan 26, 2022
View reviewed changes
src/router/Router.ts Outdated Show resolved Hide resolved
@RazzibShakya
Copy link
Contributor Author

RazzibShakya commented Jan 27, 2022 •
edited
Loading

@syaau this is ready to merge.

@syaau syaau merged commit 73d1a42 into Bhoos:master Jan 27, 2022
@RazzibShakya RazzibShakya mentioned this pull request Jan 27, 2022
Closed
@pSapien pSapien mentioned this pull request Feb 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syaau syaau syaau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RazzibShakya @syaau