Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where some colormaps were not displayed in the historam #318

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

zoccoler
Copy link
Collaborator

Colormaps from napari were not displayed on the histogram because they were not converted to matplotlib colormaps

@zoccoler zoccoler added this to the 0.8.0 milestone Jun 12, 2024
@zoccoler zoccoler added the bug Something isn't working label Jun 12, 2024
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.59%. Comparing base (30a3c0c) to head (51de90a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #318      +/-   ##
==========================================
+ Coverage   79.57%   79.59%   +0.01%     
==========================================
  Files          16       16              
  Lines        2071     2073       +2     
==========================================
+ Hits         1648     1650       +2     
  Misses        423      423              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jo-mueller
Copy link
Collaborator

Looks good!

@jo-mueller jo-mueller merged commit 5bd3d40 into main Jun 12, 2024
7 checks passed
@jo-mueller jo-mueller deleted the napari_colormaps_on_histogram branch June 12, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants