Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd attribute of task is annotated as "not empty" #56

Open
jkrue opened this issue Jun 23, 2016 · 3 comments
Open

cmd attribute of task is annotated as "not empty" #56

jkrue opened this issue Jun 23, 2016 · 3 comments

Comments

@jkrue
Copy link
Member

jkrue commented Jun 23, 2016

The cmd attribute of an task is currently annotated as required. When running a docker container with default command it isn't necessary to set a cmd here.

@jkrue jkrue self-assigned this Jun 23, 2016
@jkrue jkrue added the bug label Jun 23, 2016
@jkrue jkrue changed the title cmd attribute of task is cmd attribute of task is annotated as "not empty" Jun 23, 2016
@jkrue
Copy link
Member Author

jkrue commented Jun 23, 2016

A adhoc bugfix is to remove the "not empty" annotation from the Task definition. This change has only a small effect on the external API. Better, but then with much more API incompatibility, is to go back to the previous Task definition:

  • add an extra cmd attr for the container (which is optional)
  • choice between cmd and container (one of both is mandatory)

I integrate the adHoc solution in beta.1.release

@pbelmann
Copy link
Member

Sorry for the issue and thanks for the fix. Maybe we should schedule the fix that brings API incompatibility for beta.2.release.
@jkrue if you agree please update the label.

@jkrue
Copy link
Member Author

jkrue commented Jun 23, 2016

@pbelmann You're right ... we should integrate the API incompatible fix in beta.2.release.

@pbelmann pbelmann mentioned this issue Jun 27, 2016
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants