Rename PartData fields and use constants #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zargot
changed the title
zargot
force-pushed
the
zargot/refactor
branch
from
45413ed
to
7154b74
Compare
yulric
requested changes
Aug 23, 2022
- rename for readability in the context of the ODM - remove unused fields from PartData - simplify code - improve comments
yulric
previously approved these changes
Aug 23, 2022
zargot
force-pushed
the
zargot/refactor
branch
from
8f5eff5
to
f4e8d4a
Compare
yulric
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.