Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allowing the "orphan" resources to de rendered based on their position #13

Merged
merged 1 commit into from
Oct 29, 2020

Conversation

Mikayl
Copy link
Contributor

@Mikayl Mikayl commented Sep 24, 2020

Sorry for the delay, this should fix the situation detailed in #11 .

Not much should have been changed in regards to the mapping of the resources apart from the order that the mapping takes place.

Let me know if any changes are needed.

Tkx.

@edulix edulix mentioned this pull request Oct 17, 2020
@harshit-budhraja harshit-budhraja self-assigned this Oct 17, 2020
@harshit-budhraja harshit-budhraja added this to the 1.0.3 milestone Oct 29, 2020
@harshit-budhraja harshit-budhraja added the enhancement Enhancement to an existing feature (major or minor) label Oct 29, 2020
@harshit-budhraja harshit-budhraja changed the base branch from master to NP-milestone-1_0_3 October 29, 2020 11:20
@harshit-budhraja harshit-budhraja merged commit 3c0e097 into BigBasket:NP-milestone-1_0_3 Oct 29, 2020
@harshit-budhraja
Copy link
Contributor

Hi @Mikayl, this looks good, thanks to you.
We've accommodated these changes in the upcoming release (1.0.3).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to an existing feature (major or minor)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants