Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple improvements #16

Merged
merged 10 commits into from
Oct 29, 2020
Merged

Conversation

edulix
Copy link
Contributor

@edulix edulix commented Oct 17, 2020

This pull includes several improvements:

@harshit-budhraja harshit-budhraja self-assigned this Oct 17, 2020
@harshit-budhraja harshit-budhraja added enhancement Enhancement to an existing feature (major or minor) bug Something isn't working labels Oct 29, 2020
@harshit-budhraja harshit-budhraja added this to the 1.0.3 milestone Oct 29, 2020
@harshit-budhraja harshit-budhraja linked an issue Oct 29, 2020 that may be closed by this pull request
@harshit-budhraja harshit-budhraja changed the base branch from master to NP-milestone-1_0_3 October 29, 2020 11:16
@harshit-budhraja harshit-budhraja changed the base branch from NP-milestone-1_0_3 to NP-edulix-patch October 29, 2020 11:23
@harshit-budhraja harshit-budhraja merged commit ab53678 into BigBasket:NP-edulix-patch Oct 29, 2020
@harshit-budhraja harshit-budhraja linked an issue Oct 29, 2020 that may be closed by this pull request
@harshit-budhraja
Copy link
Contributor

Hi @edulix !! Thank you so much for such rich contributions to improve the overall codebase for ra-treemenu. Really appreciate it! 💯
P.S. We've accommodated these changes in the upcoming release (1.0.3).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement Enhancement to an existing feature (major or minor)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CustomMenuItem only translates name when menu is not open Missing key prop on parent resource.
2 participants