Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

L10N - would it be possible to translate this tool? #21

Closed
Jibec opened this issue Apr 26, 2017 · 7 comments
Closed

L10N - would it be possible to translate this tool? #21

Jibec opened this issue Apr 26, 2017 · 7 comments
Assignees
@BigE
Labels
enhancement

Comments

@Jibec
Copy link
Contributor

Jibec commented Apr 26, 2017 •
edited

hi, I would really like to translate this application, would it be possible to add the localization support?
In addition, I assume directly connecting you project to https://hosted.weblate.org or whatever translation platform of your choice would be great!

thanks a lot for your help!
@BigE
Copy link
Owner

BigE commented Apr 26, 2017

I would love to add localization support, great idea! I'll work this into the next feature release that I make. Not sure when that will be, but I'll update this as I work through it. Thanks!

@BigE BigE self-assigned this Apr 26, 2017
BigE added a commit that referenced this issue Apr 28, 2017
@BigE
localization creation for extension, see #21
f7e41de
BigE added a commit that referenced this issue Apr 28, 2017
@BigE
localization creation for daemon, see #21
c158b96
@Jibec
Copy link
Contributor Author

Jibec commented May 19, 2017

I glad to see this! Please let me know when I can send you a translated version so we can test this together :)

@BigE
Copy link
Owner

BigE commented Aug 27, 2017

I've updated the file paths in the develop branch, please let me know if you can test this still. Thanks!

BigE added a commit that referenced this issue Sep 12, 2017
@BigE
Merge tag 'version-24' into develop
1844a81 
Multiple bugfixes and improvements made

This release adds several enhancements and bugfixes with the following
issues: #21, #23, #24, #28, and #29. The biggest change in this release is
how the daemon handles profiles, along with the extension flow of the rotation
setting.
@Jibec
Copy link
Contributor Author

Jibec commented Sep 18, 2017

He are the files, I don't have an example to know where to put them in git :(
"Remember the profiles current/next wallpaper" => what are we talking about?
"DeskChanger" => I understand we should not translate it
"LockScreen" => it's written like we shouldn't translate it, but I feel like we should translate it, isn't it?
"Show Preview as Icon" => is Preview translatable?

Github doesn't accept po files in issues, so it's txt...
desk-changer.fr.txt
desk-changer-daemon.fr.txt

Next step for your software : add a desktop file and make it translatable :p
Next step for translation : use a translation platform ;)

@BigE
Copy link
Owner

BigE commented Sep 18, 2017

He are the files, I don't have an example to know where to put them in git :(

Just put the po files into the po folder under the language you're translating. For this, just create po/fr/ and place the .po files in that folder.

"Remember the profiles current/next wallpaper" => what are we talking about?

This is the daemon's ability to remember the currently set wallpaper and the next in queue wallpaper when it shuts down. Thus, when it is started again, it begins where it left off.

"DeskChanger" => I understand we should not translate it

No, this is the name of the extension.

"LockScreen" => it's written like we shouldn't translate it, but I feel like we should translate it, isn't it?

Might just dig into gnome and see how they handle it? I took the terminology from them directly.

"Show Preview as Icon" => is Preview translatable?

I would assume so, the preview is just a display of the next wallpaper to be set to the desktop.

Github doesn't accept po files in issues, so it's txt...
desk-changer.fr.txt
desk-changer-daemon.fr.txt

Next step for your software : add a desktop file and make it translatable :p
Next step for translation : use a translation platform ;)

I need to get a build process going in the project to automate a few things... this will be one of them. Thanks for the time and effort on this!

To get all this added, just add your po files in the folders discussed above and create a pull request. Once that's done, I can start working on a build process to automate the creation of the files for the extension itself. Once that's done, I can make a release with the new translations. Thanks!

BigE pushed a commit that referenced this issue Oct 4, 2017
@Jibec @BigE
Adding fr translations from #21
08403d8
BigE added a commit that referenced this issue Oct 4, 2017
@BigE
Merge tag 'version-26' into develop
599220b 
This release is primarily a bugfix release

This release fixes #31 and closes #21 by finally adding translation support. It
also adds a Makefile with basic build and installation support. I've also snuck
in a bump to support Gnome 3.26
@BigE
Copy link
Owner

BigE commented Oct 4, 2017

Translations provided are in the newest release. Please feel free to fork and submit merge requests from here on out. I've also added a basic Makefile for build support... it should get things working at the least. Thanks for the contribution!

@BigE BigE closed this as completed Oct 4, 2017
@Jibec
Copy link
Contributor Author

Jibec commented Oct 4, 2017

thanks for the attribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BigE BigE

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BigE @Jibec