Add strange-forms examples and GitHub pages #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinivy
commented
Jul 16, 2021
devinivy
commented
Jul 16, 2021
devinivy
commented
Jul 16, 2021
devinivy
commented
Jul 16, 2021
devinivy
commented
Jul 16, 2021
devinivy
commented
Jul 16, 2021
bmleight
approved these changes
Jul 16, 2021
There was a problem hiding this comment.
Sorry for the delayed review (and for submitting this right after you merge it in...)! I started this earlier in the week, and then it got lost in my sea of tabs. I just made a few suggestions on the install instructions for the examples. Thanks for the great examples, it was nice to checkout some strangeluv code again.
| Click the green "Use this template" button above or install manually using git: | ||
|
|
||
| ```bash | ||
| $ git clone --depth=1 --origin=strangeluv --branch=strangeluv git@github.com:bigroomstudios/strangeluv.git my-project |
There was a problem hiding this comment.
Suggested change
| $ git clone --depth=1 --origin=strangeluv --branch=strangeluv git@github.com:bigroomstudios/strangeluv.git my-project | |
| $ git clone git@github.com:BigRoomStudios/strange-forms.git |
|
|
||
| ```bash | ||
| $ git clone --depth=1 --origin=strangeluv --branch=strangeluv git@github.com:bigroomstudios/strangeluv.git my-project | ||
| $ cd my-project |
There was a problem hiding this comment.
Suggested change
| $ cd my-project | |
| $ cd strange-forms/examples |
| ```bash | ||
| $ git clone --depth=1 --origin=strangeluv --branch=strangeluv git@github.com:bigroomstudios/strangeluv.git my-project | ||
| $ cd my-project | ||
| $ git checkout --orphan master # New branch without history |
There was a problem hiding this comment.
Suggested change
| $ git checkout --orphan master # New branch without history |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intention of this work is to document clearly how strange-forms works and how one might use it in various situations, through example. The provided examples are:
These are deployed to GitHub pages here: https://bigroomstudios.github.io/strange-forms. Each page also contains a short explainer, mentioning general pitfalls that may arise when implementing this example.
In order to illustrate the inner-workings of strange-forms, there is also a concise reference implementation using hooks, which is used to re-implement versions of the Controlled and Uncontrolled examples.