-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/fastlane #1
Conversation
apt-get install -y qt5-default | ||
apt-get install -y ruby-full build-essential dh-autoreconf | ||
|
||
RUN gem install fastlane -NV --no-document |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work getting fastlane into linux!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it should be easier in the future: they're supposed to be working on a multi-platform support or at least, they've got an issue open for it! (fastlane/fastlane#11687)
For reference, I found the fix here:
fastlane/fastlane#11579
@@ -29,17 +31,8 @@ RUN mkdir -p /opt/android-sdk && cd /opt/android-sdk && \ | |||
unzip *tools*linux*.zip && \ | |||
rm *tools*linux*.zip | |||
|
|||
# download and install Kotlin compiler | |||
ENV KOTLIN_VERSION 1.2.61 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I'm guessing gradle will download Kotlin on demand?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I'm pretty sure it is actually already doing that by itself and that version of the compiler is never used by the Android build => the Kotlin compiler is a dependency of the Kotlin gradle plugin
(maybe the KOTLIN_HOME variable overrides the normal behaviour but I doubt it)
And it's actually a lot better to not care about the version installed on our build machines and declare it project by project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Added Fastlane and removed some unused dependencies (Qt and Kotlin compiler)
For reference, fix for Fastlane integration on Ubuntu:
fastlane/fastlane#11579