switches to Fowler-Noll-Vo hash algorithm for hashing names #1221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous algorithm had a very bad collision rate, especially for small strings. The new one is much better and is tested on large dictionaries (of English words and password) and is guaranteed not to collide on small strings. Warning: the change of the hash function will break the knowledge base format so do `bap --cache-clean` after the update.
ivg
force-pushed
the
better-name-hash
branch
from
0b6f62a
to
05b42de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous algorithm had a very bad collision rate, especially for
small strings. The new one is much better and is tested on large
dictionaries (of English words and large password databases,
with no collisions found) and is guaranteed not to collide on small strings,
which were tested exhaustively.
Warning: the change of the hash function will break the knowledge base
format so do
bap --cache-cleanafter the update.