silenced warnings from ours deprecations #885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR silences warnings from bap code during compilation of bap itself. Also, it turned out that few modules in `bap.mli` were deprecated in a way that doesn't emit warnings at all: Just for the record, the next doesn't deprecate `module A`, because according to the documentation for attributes of level 3: > They are not attached to any specific node in the syntax tree ``` module A = struct [@@@deprecated "[since ...]"] ... end ``` And the next works as expected, although in this case we have do the deprecation in the end of module, which makes it less readable. But anyway, looks like we don't have any other choice. ``` module A = struct ... end [@@deprecated "[since ...]"] ```
ivg
requested changes
Oct 5, 2018
gitoleg
force-pushed
the
resolves-warnings
branch
from
976df0b
to
1a0956f
Compare
ivg
approved these changes
Oct 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR silences warnings from bap code during compilation of bap itself. Also, it turned out that few modules in
bap.mliwere deprecated in a way that doesn't emit warnings at all.Just for the record, the next sample doesn't deprecate
module A, because according to the documentation for attributes of level 3:And the next works as expected, although in this case, we have to do the depreciation at the end of the module, which makes it less readable for a user. But anyway, looks like we don't have any other choice.