Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color debug status bar #374

Closed
JMS55 opened this issue Jan 21, 2020 · 15 comments
Closed

Color debug status bar #374

JMS55 opened this issue Jan 21, 2020 · 15 comments

Comments

@JMS55
Copy link

JMS55 commented Jan 21, 2020

No description provided.

@Binaryify
Copy link
Owner

could you provide more infomation

@JMS55
Copy link
Author

JMS55 commented Feb 29, 2020

When debugging, the status bar turns purple. Not sure what a better color would be, but I'm not a fan of the purple.
image

@Binaryify
Copy link
Owner

I just change that, you can check it later~

@JMS55
Copy link
Author

JMS55 commented Mar 26, 2020

Looks good!

@JMS55 JMS55 closed this as completed Mar 26, 2020
@tristan957
Copy link

Hi @Binaryify, I really like the debug status bar color. Something I noticed in a recent debugging session was that hovering status bar elements during a debug session lost the orange color (One Dark Pro Darker). The hover color was the same or nearly the same as the default status bar color.

Happy to try to provide a screenshot if you can't reproduce what I am talking about or don't understand it.

@Binaryify
Copy link
Owner

@tristan957 are you using flat theme now

@tristan957
Copy link

No, actually my theme is just the plain "One Dark Pro"

@Binaryify
Copy link
Owner

@tristan957 just fixed that in v3.13.26, you can check it now

@skilkis
Copy link
Contributor

skilkis commented May 12, 2022

@Binaryify thanks for all of your hard work creating and maintaining One Dark Pro! 🎉 A few years ago I opened the original PR on One Dark Pro Flat #One Dark Pro Flat. Are you open to changing the flat theme debug color back to something that is monochrome? If not, it's not a big deal and I can keep using the previous color by changing my local configuration 😊

@skilkis
Copy link
Contributor

skilkis commented May 12, 2022

I see now that some changes were incorporated by #726 which removed visual semantics of when the debugger was active

@Binaryify
Copy link
Owner

@skilkis I think debugging status bar background should be special, if you like the old one, you can just custom it in your setting.json

@skilkis
Copy link
Contributor

skilkis commented May 12, 2022

@Binaryify I completely agree with you. To clarify what I meant was pre #726 behavior as follows:

image

Indeed I can change it in settings.json 😊

@tristan957
Copy link

tristan957 commented May 12, 2022

@Binaryify I got a picture of what I was talking about. That is me hovering that part of the status bar.
image

@Binaryify
Copy link
Owner

Binaryify commented May 13, 2022

@tristan957 it is a bug, I just delete the statusBarItem.hoverBackground in v3.13.27, and it look normal now
image

@Binaryify
Copy link
Owner

Binaryify commented May 13, 2022

@tristan957 in v3.13.29, it look like this
image

image

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants