Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C# - Highlighting Error #493

Closed
NickITGuy opened this issue Dec 9, 2020 · 6 comments
Closed

C# - Highlighting Error #493

NickITGuy opened this issue Dec 9, 2020 · 6 comments
Labels

Comments

@NickITGuy
Copy link

Describe the bug
It seems certain parameters have no highlighting applied to them

To Reproduce
Steps to reproduce the behavior:

  1. Download C# Extensions from Microsoft.
  2. Open a C# file (Make sure to say yes if VSCode asks to add missing dependencies.

Expected behavior
I am hoping to get the parameter to be highlighted or colored correctly so its less jarring

Screenshots & Example Code
Screenshot 2020-12-09 184828

Desktop (please complete the following information):

  • OS: Windows 10 Pro x64 Bit.
  • VSCODE Version 1.51.1
  • Theme version 3.9.11

Additional context
I will also provide a small snippet of test code to help reproduce the error

`using System;
using System.Collections.Generic;

namespace GradeBook
{
public class Book
{
public Book(string name)
{
grades = new List();
this.name = name;
}

    public void AddGrade(double grade)
    {
        grades.Add(grade);
    }

    public Statistics GetStatistics()
    {
        var result = new Statistics();
        result.Average = 0.0;
        result.High = double.MinValue;
        result.Low = double.MaxValue;

        foreach (var grade in grades)
        {
            result.Low = Math.Min(grade, result.Low);
            result.High = Math.Max(grade, result.High);
            result.Average += grade;
        }
        result.Average /= grades.Count;

        return result;
    }

    private List<double> grades;
    public string name;
}

}`

@NickITGuy NickITGuy added the bug label Dec 9, 2020
@Binaryify
Copy link
Owner

what is your expected about the color

@NickITGuy
Copy link
Author

I think either the same purple as before the lines or a red maybe? Just something that fits in with the current color scheme rather than a grey. :)

Thanks

@Binaryify
Copy link
Owner

how about this
image

@NickITGuy
Copy link
Author

wow it looks heaps better. :)

@Binaryify
Copy link
Owner

just release a new version, you can check it now

@NickITGuy
Copy link
Author

Great! Thank you very much for the prompt fix. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants