Make -renormalize work on the top mip-level too (opt-out option) #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some tools scale the vectors in normalmaps to maximum length for increased precision, but that breaks reconstruction of the z part in DXN compressed normal maps. Passing -renormalize on compression fixes those textures now.
Dæmon engine users can use -renormalize -rtopmip
11 tasks
illwieckz
added a commit
to illwieckz/crunch
that referenced
this pull request
Jun 16, 2019
FreeBSD: fix malloc in crn_decomp single header file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Dæmon-based games like Unvanquished, we need to renormalize on the top of mip-level too.
Until now, we used an old crunch fork that was patched by @gimhael on this purpose, he said in that time:
This PR reports the change to upstream, making it as an opt-out option to not change the default
-renormalizebehavior.Dæmon engine users can do
crunch -renormalize -rtopmipto get the behavior they need.