Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Varargs to vectors or array #24

Closed
TransGirlCodes opened this issue Aug 14, 2017 · 0 comments
Closed

Change Varargs to vectors or array #24

TransGirlCodes opened this issue Aug 14, 2017 · 0 comments

Comments

@TransGirlCodes
Copy link
Member

TransGirlCodes commented Aug 14, 2017

function count_pairwise{P<:Position,A<:NucAlphs,N}(::Type{P}, seqs::Vararg{BioSequence{A},N})

@bicycle1885 There was an issue or PR recently in which you recommended removing Varargs and just going with a general iterable.

I'm considering whether I should change the varargs in the signature to some other container type, perhaps add a parameter for AbstractArray like:

count_pairwise{P<:Position,A<:NucAlphs,C<:AbstractArray}(::Type{P}, seqs::C{BioSequence{A},N})

I already have a plan to cleanup the fast counting internals a bit and wondered if it was worth doing this at the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant