Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move some indexing logic from LongSequence to BioSequence #133

Merged
merged 3 commits into from
Mar 10, 2021

Conversation

jakobnissen
Copy link
Member

This simply moves some of the general indexing logic from LongSequence to BioSequence, to make it more general. For example, you can now do

julia> a = dna"TAGC";

julia> a[2:4] = mer"ATG";

julia> a
4nt DNA Sequence:
TATG

@codecov
Copy link

codecov bot commented Feb 25, 2021

Codecov Report

Merging #133 (d0fef87) into master (2527208) will decrease coverage by 0.51%.
The diff coverage is 60.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #133      +/-   ##
==========================================
- Coverage   83.04%   82.52%   -0.52%     
==========================================
  Files          45       45              
  Lines        3061     3073      +12     
==========================================
- Hits         2542     2536       -6     
- Misses        519      537      +18     
Flag Coverage Δ
unittests 82.52% <60.52%> (-0.52%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/biosequence/indexing.jl 70.42% <21.05%> (-23.92%) ⬇️
src/longsequences/indexing.jl 100.00% <100.00%> (ø)
src/longsequences/seqview.jl 93.54% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2527208...6b693c8. Read the comment docs.

@jakobnissen jakobnissen merged commit 0ba3d4b into BioJulia:master Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant