Remove conversion to/from integers and kmers, and direct instantiatio… #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n of kmers from integers.
Users should instead use `masked(::Type{T}, x::Unsigned)` to create kmers from integers, and `reinterpret` to create integers from kmers.
Codecov Report
@@ Coverage Diff @@
## v3 #147 +/- ##
==========================================
- Coverage 83.24% 82.96% -0.29%
==========================================
Files 40 40
Lines 2602 2594 -8
==========================================
- Hits 2166 2152 -14
- Misses 436 442 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n of kmers from integers. See issue #145
Users should instead use
masked(::Type{T}, x::Unsigned)to create kmers from integers, andreinterpretto create integers from kmers.