Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop pirating BioSymbols #259

Merged
merged 1 commit into from
Nov 12, 2022
Merged

Stop pirating BioSymbols #259

merged 1 commit into from
Nov 12, 2022

Conversation

jakobnissen
Copy link
Member

BioSequences pirated BioSymbols by overloading gap, isambigous, isgap and iscertain. Remove these overloads.

This is a draft because it depends on a yet-unreleased version of BioSymbols.

BioSequences pirated BioSymbols by overloading `gap`, `isambigous`, `isgap` and
`iscertain`. Remove these overloads.
@codecov
Copy link

codecov bot commented Nov 12, 2022

Codecov Report

Base: 88.49% // Head: 88.53% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (2366628) compared to base (e4c8997).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #259      +/-   ##
==========================================
+ Coverage   88.49%   88.53%   +0.03%     
==========================================
  Files          31       31              
  Lines        2330     2329       -1     
==========================================
  Hits         2062     2062              
+ Misses        268      267       -1     
Flag Coverage Δ
unittests 88.53% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/BioSequences.jl 100.00% <ø> (+5.55%) ⬆️
src/biosequence/counting.jl 96.55% <100.00%> (ø)
src/longsequences/counting.jl 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jakobnissen jakobnissen marked this pull request as ready for review November 12, 2022 13:49
@jakobnissen jakobnissen merged commit db8a692 into BioJulia:master Nov 12, 2022
@jakobnissen jakobnissen deleted the piracy branch November 12, 2022 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant