Fast ASCII String to LongSequence conversion #81
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fast ASCII String to LongSequence conversion
This PR makes it so that if a LongSequence is constructed from a String, or
encode_copy!
'ed from a String, it detects if the String is an ASCII string. If so, it wraps a byte vector around it and uses the faster vector to LongSequence conversion path.Edit: Should probably post some benchmarks. Here, I run
LongSequence{DNAAlphabet{4}}(st)
for varying lengths of string: