Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SIMD code generator #42

Closed
wants to merge 5 commits into from
Closed

Conversation

jakobnissen
Copy link
Member

This PR is only compatible with BioJulia/Automa.jl#60 - so it can't be merged yet. I'm ambivalent as to whether this should be merged at all.

See that PR for the pros/cons

@codecov
Copy link

codecov bot commented Jun 23, 2021

Codecov Report

Merging #42 (79dd2c2) into release-2 (e9202ba) will decrease coverage by 2.94%.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           release-2      #42      +/-   ##
=============================================
- Coverage      83.57%   80.63%   -2.95%     
=============================================
  Files             11       12       +1     
  Lines            615      661      +46     
=============================================
+ Hits             514      533      +19     
- Misses           101      128      +27     
Flag Coverage Δ
unittests 80.63% <0.00%> (-2.95%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/fasta/readrecord.jl 96.42% <ø> (ø)
src/fastq/readrecord.jl 46.15% <0.00%> (ø)
src/fasta/record.jl 65.24% <0.00%> (-15.05%) ⬇️
src/fastq/reader.jl 89.36% <0.00%> (-1.12%) ⬇️
src/fastq/record.jl 82.39% <0.00%> (-1.07%) ⬇️
src/fasta/reader.jl 89.85% <0.00%> (-0.63%) ⬇️
src/fasta/index.jl 100.00% <0.00%> (ø)
src/FASTX.jl 100.00% <0.00%> (ø)
src/fastq/writer.jl 96.77% <0.00%> (+0.22%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9202ba...79dd2c2. Read the comment docs.

@jakobnissen jakobnissen changed the base branch from master to release-2 November 29, 2021 12:07
@jakobnissen
Copy link
Member Author

Okay, here is what need to happen before I am comfortable merging this:

@jakobnissen
Copy link
Member Author

This will be made obsolete with Automa v1, which will hopefully land in a few months at most

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant