Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump BioSequences/FASTX to v3/v2 #16

Merged
merged 8 commits into from
Mar 6, 2023

Conversation

banhbio
Copy link
Contributor

@banhbio banhbio commented Mar 5, 2023

Bump BioSequences/FASTX to v3/v2

Types of changes

This PR implements the following changes:
(Please tick any or all of the following that are applicable)

  • ✨ New feature (A non-breaking change which adds functionality).
  • πŸ› Bug fix (A non-breaking change, which fixes an issue).
  • πŸ’₯ Breaking change (fix or feature that would cause existing functionality to change).

πŸ“‹ Additional detail

This PR is to follow the latest BioSequences and FASTX.

The changes are as follows.

β˜‘οΈ Checklist

  • 🎨 The changes implemented is consistent with the julia style guide.
  • πŸ“˜ I have updated and added relevant docstrings, in a manner consistent with the documentation styleguide.
  • πŸ“˜ I have added or updated relevant user and developer manuals/documentation in docs/src/.
  • πŸ†— There are unit tests that cover the code changes I have made.
  • πŸ†— The unit tests cover my code changes AND they pass.
  • πŸ“ I have added an entry to the [UNRELEASED] section of the manually curated CHANGELOG.md file for this repository.
  • πŸ†— All changes should be compatible with the latest stable version of Julia.
  • πŸ’­ I have commented liberally for any complex pieces of internal code.

@jakobnissen
Copy link
Member

CI seems OK. It fails on Windows but there is a TODO in the code that mentions this failure so it's probably not this PRs fault.

I'll review it closer in a few hours, then I'll merge. Let's make an issue on the Windows failure so we don't lose track of it - perhaps you can track that bug down?

Copy link
Member

@jakobnissen jakobnissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a second look, it looks like this fix is deleted in the PR?

@banhbio
Copy link
Contributor Author

banhbio commented Mar 6, 2023

Thanks for checking.
I mistakenly thought that the windows bug was already fixed in FASTX.jl.
I need to revert this change.

@jakobnissen jakobnissen merged commit ac218f6 into BioJulia:master Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants