Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't import biopandas during install #60

Merged
merged 5 commits into from
Oct 10, 2019
Merged

Don't import biopandas during install #60

merged 5 commits into from
Oct 10, 2019

Commits on Oct 10, 2019

  1. Don't import biopandas during install 

    Getting the __version__ during install is more safely done by reading __init__ as text.

The reason is that __init__ may at some point include code that requires importing packages that have not yet been installed. Installing a package should always be possible using `pip install biopython` in an empty virtualenv.
    @ecederstrand
    ecederstrand committed Oct 10, 2019
    Configuration menu
    Copy the full SHA
    43cef04 View commit details
    Browse the repository at this point in the history

  2. Fix pep8

    @ecederstrand
    ecederstrand committed Oct 10, 2019
    Configuration menu
    Copy the full SHA
    c8c0b28 View commit details
    Browse the repository at this point in the history

  3. Update setup.py

    @ecederstrand
    ecederstrand committed Oct 10, 2019
    Configuration menu
    Copy the full SHA
    b7cd754 View commit details
    Browse the repository at this point in the history

  4. Fix imports

    @ecederstrand
    ecederstrand committed Oct 10, 2019
    Configuration menu
    Copy the full SHA
    f531786 View commit details
    Browse the repository at this point in the history

  5. Fix for Python 2.7

    @ecederstrand
    ecederstrand committed Oct 10, 2019
    Configuration menu
    Copy the full SHA
    993f6be View commit details
    Browse the repository at this point in the history