-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't import biopandas during install #60
Conversation
Getting the __version__ during install is more safely done by reading __init__ as text. The reason is that __init__ may at some point include code that requires importing packages that have not yet been installed. Installing a package should always be possible using `pip install biopython` in an empty virtualenv.
Hello @ecederstrand! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2019-10-10 18:09:48 UTC |
Thanks for the PR. Just making sure that I understand the rationale correctly. So, the argument is that if we accumulate a lot of stuff in the I am not sure if this is an issue here, because we do not import external packages in the |
It's correct that this isn't an issue right now because the init doesn't contain any import statements. But if you start adding import helpers so you can do Anyway, I just wanted to raise the issue here since I've wasted countless hours due to this in other projects :-) |
Yeah, it certainly doesn't hurt to add this. I'd be happy to merge this once the issues are fixed. |
Wow, I really botched this PR. Sorry. Copy-pasting code and editing files online on GitHub is not a good combination :-) |
Looks good, thx! Doc updates etc are not required, because these are just changes under the hood. Will merge. Thanks! |
* Don't import biopandas during install Getting the __version__ during install is more safely done by reading __init__ as text. The reason is that __init__ may at some point include code that requires importing packages that have not yet been installed. Installing a package should always be possible using `pip install biopython` in an empty virtualenv. * Fix pep8 * Update setup.py * Fix imports * Fix for Python 2.7
Getting the version during install is more safely done by reading init as text.
The reason is that init may at some point include code that requires importing packages that have not yet been installed. Installing a package should always be possible using
pip install biopython
in an empty virtualenv.Description
Insert Description Here
Related issues or pull requests
Link related issues/pull requests here
Pull Request requirements
For new features or bug fixes, pleas consider the following to-do list:
./biopandas/*/tests
directoriesnosetests ./biopandas -sv
and make sure that all unit tests passnosetests ./biopandas --with-coverage
flake8 ./biopandas
./docs/sources/
CHANGELOG.md` filebiopandas/docs/sources/
(optional)