Skip to content

Commit

Permalink
Fix embedded iframe problem with PDF outputs.
Browse files Browse the repository at this point in the history
The iframe tag is a "content tag" and must have an explicit closing tag. This
was causing outputs listed after an inlined PDF to not show up.

See: https://jira.biovel.eu/browse/TAV-527
  • Loading branch information
hainesr committed Nov 11, 2014
1 parent 2569631 commit bc0a1c7
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions lib/taverna_player_renderers.rb
Expand Up @@ -46,10 +46,10 @@ def format_xml(port, index = [])
end

def inline_pdf(port, index = [])
"If you do not see the PDF document displayed in the browser below, "\
"please download it (using the button above) and load it into a PDF "\
"reader application on your local machine.<br/>" +
tag(:iframe, :src => port.path(index), :class => "inline_pdf")
"If you do not see the PDF document displayed in the browser below, please
download it (using the button above) and load it into a PDF reader
application on your local machine.<br />" +
content_tag(:iframe, nil, :src => port.path(index), :class => "inline_pdf")
end

def format_error(port, index = [])
Expand Down

0 comments on commit bc0a1c7

Please sign in to comment.