Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Use of png images #12

Closed
drisso opened this issue Jun 28, 2018 · 6 comments
Closed

Use of png images #12

drisso opened this issue Jun 28, 2018 · 6 comments
Labels
question Further information is requested

Comments

@drisso
Copy link
Collaborator

drisso commented Jun 28, 2018

Hi,

in last year's workshop, we started our Rmd file with a schema of a typical single-cell workflow, which we included simply by using

knitr::include_graphics("schema_workflow.png")

That means including a (small) png file to the repository. Is that OK, or is it discouraged?

@risserlin
Copy link
Collaborator

I have the same question. Would it be ok to add a directory called images and put all my images in it?

@mtmorgan
Copy link
Contributor

Without knowing the technical details, I think there should be structure so each workshop is acting +/- independently of the other, e.g., a folder rather than top-level Rmd file for each workshop. That way one can at least associate images & other resources with workshops, and one knows who to contact if things get out of hand...

@sa-lee
Copy link
Collaborator

sa-lee commented Jun 28, 2018

I'm also interested in this - @mtmorgan is what you're suggesting to go for something like:

./Lee_Plyranges/
    Lee_Plyranges.Rmd
    ref.bib
    figures/

and set the fig.path option in the Rmd file?

@mtmorgan
Copy link
Contributor

@sa-lee yep exactly

@LiNk-NY
Copy link
Collaborator

LiNk-NY commented Jun 28, 2018

I don't think this current structure is supported for bookdown. See here: rstudio/bookdown#107
It seems like all Rmd files should be in the root folder and data / image files etc. could be in a folder.

Alternative:

./Lee_Plyranges.Rmd
./Lee_Plyranges
    ref.bib
    figures/

lshep added a commit to jmacdon/Bioc2018Anno that referenced this issue Jun 29, 2018
  - organizers didn't encourage presentation format
  - used syllabi as base and added presentation Rmd
  - decreased each section header (ie. ## becomes ###) to be consistent with bookdown chapters
  - moved pngs to subdirectory as suggested in Bioconductor/BiocWorkshops#12
@lwaldron lwaldron added the question Further information is requested label Jul 7, 2018
@PeteHaitch PeteHaitch reopened this Jul 10, 2018
@LiNk-NY
Copy link
Collaborator

LiNk-NY commented Jul 30, 2018

Note: PNGs are preferred especially when building the PDF version of the book.

@LiNk-NY LiNk-NY closed this as completed Jul 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

7 participants