Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

220_Das_SingleCellRNASeq.Rmd #22

Closed
lwaldron opened this issue Jul 7, 2018 · 20 comments
Closed

220_Das_SingleCellRNASeq.Rmd #22

lwaldron opened this issue Jul 7, 2018 · 20 comments

Comments

@lwaldron
Copy link
Collaborator

lwaldron commented Jul 7, 2018

I'm creating an issue for each workshop, to be closed when both 1) the workshop is complete, and 2) it compiles without problems. Please note problems and status updates here.

aroma.light issue, to be resolved on server side.

@lwaldron
Copy link
Collaborator Author

lwaldron commented Jul 7, 2018

it looks like for a couple of workshops (including ours) the problem is that aroma.light is failing its checks in bioc-devel and hence biocLite won't be able to install it. Any workaround? Or should we ask @HenrikBengtsson to fix it? :)

The workaround is to install https://cran.r-project.org/src/contrib/Archive/princurve/princurve_1.1-12.tar.gz or GitHub devel branch of princurve. The reason is Issue rcannood/princurve#8.

@lwaldron lwaldron added this to To do in Complete workshops Jul 7, 2018
@lwaldron lwaldron added this to In progress in Complete the Workshops Jul 7, 2018
@lwaldron
Copy link
Collaborator Author

lwaldron commented Jul 9, 2018

Getting a new problem now that aroma.light is installed from HenrikBengtsson/aroma.light:

Quitting from lines 386-390 (220_Das_SingleCellRNASeq.Rmd) 
Error in project_to_curve(X, s, pcurve$ord, stretch = stretch) : 
  unused argument (pcurve$ord)
Calls: <Anonymous> ... getCurves -> .local -> lapply -> FUN -> .shrink_to_avg
In addition: Warning messages:
1: In rgl.init(initValue, onlyNULL) : RGL: unable to open X11 display
2: 'rgl_init' failed, running with rgl.useNULL = TRUE 
Execution halted

@lwaldron lwaldron added problems Something isn't working and removed status unknown labels Jul 9, 2018
@HenrikBengtsson
Copy link

That:

Error in project_to_curve(X, s, pcurve$ord, stretch = stretch) : 
  unused argument (pcurve$ord)

appears to come from princurve. For troubleshooting purposes, see if it works with https://cran.r-project.org/src/contrib/Archive/princurve/princurve_1.1-12.tar.gz.

BTW, what timeline are you on here? I can try to push for a CRAN update of princurve - they seem to be willing to make a new release quite soon.

@LiNk-NY
Copy link
Collaborator

LiNk-NY commented Jul 9, 2018

Hi Henrik,
I get a different error:

Quitting from lines 393-397 (220_Das_SingleCellRNASeq.Rmd) 
Error: package 'princurve' 1.1.12 is loaded, but >= 2.0.2 is required by 'slingshot'
Execution halted

@kstreet13
Copy link
Collaborator

Hey all,
The project_to_curve function was added in princurve version 2.0.2 (it was previously called get.lam), so I think updating that package may solve this issue.

@rcannood
Copy link

rcannood commented Jul 9, 2018

The problem with aroma.light has been fixed with princurve 2.0.4, which is now available on CRAN. Please use that version, instead of the @devel version on GitHub.

@LiNk-NY LiNk-NY added looks OK and removed problems Something isn't working labels Jul 9, 2018
@LiNk-NY
Copy link
Collaborator

LiNk-NY commented Jul 9, 2018

Thanks!

@rcannood
Copy link

rcannood commented Jul 9, 2018

And the problem with slingshot is being caused by princurve 2.0.4. kstreet13/slingshot#19 should do the trick.

@HenrikBengtsson
Copy link

I can confirm that aroma.light passes R CMD check --as-cran with the princurve 2.0.4 that just hit CRAN. I've/Travis CI/AppVeyor CI verified on Linux and Windows with various R versions - as soon as macOS binaries are rolled out, I'd expect it to also work there too. This means that aroma.light should build and pass all checks on Bioc release & devel at the next round of Bioc builds.

@LiNk-NY LiNk-NY added problems Something isn't working and removed looks OK labels Jul 10, 2018
@LiNk-NY
Copy link
Collaborator

LiNk-NY commented Jul 10, 2018

Quitting from lines 400-404 (220_Das_SingleCellRNASeq.Rmd) 
Error in project_to_curve(X, s, pcurve$ord, stretch = stretch) : 
  unused argument (pcurve$ord)
Calls: local ... getCurves -> .local -> lapply -> FUN -> .shrink_to_avg
In addition: Warning messages:
1: In rgl.init(initValue, onlyNULL) : RGL: unable to open X11 display
2: 'rgl_init' failed, running with rgl.useNULL = TRUE 
Execution halted
Error in Rscript_render(f, render_args, render_meta) : 
  Failed to compile 220_Das_SingleCellRNASeq.Rmd
Calls: <Anonymous> ... render_new_session -> tryCatch -> tryCatchList -> Rscript_render
Execution halted

Exited with status 1.

@rcannood
Copy link

kstreet/slingshot#19 was merged yesterday, but slingshot v 0.99.11 still needs to be published on Bioconductor. Once slingshot v 0.99.11 is out, this error should disappear :)

@kstreet13
Copy link
Collaborator

Yeah, I pushed the new version yesterday, so it should be available soon!

@drisso
Copy link
Collaborator

drisso commented Jul 17, 2018

Hi @LiNk-NY ,

can you confirm that the new version of slingshot solves the issue above? It works on my local machine with slingshot 0.99.12 and princurve 2.1.0, but not sure which versions you have for the build.

@LiNk-NY LiNk-NY added looks OK and removed problems Something isn't working labels Jul 17, 2018
@LiNk-NY
Copy link
Collaborator

LiNk-NY commented Jul 17, 2018

Hi Davide, @drisso
The builder has these versions:

> packageVersion("slingshot")
[1] ‘0.99.12’
> packageVersion("princurve")
[1] ‘2.1.0’

and it solves the issue. Thanks.

@drisso
Copy link
Collaborator

drisso commented Jul 17, 2018

Awesome! Thanks Marcel!

@LiNk-NY LiNk-NY added problems Something isn't working and removed looks OK labels Jul 18, 2018
@LiNk-NY
Copy link
Collaborator

LiNk-NY commented Jul 18, 2018

Hi Diya, @diyadas
Could you please fix the citations in your workshop? I don't see any entries in the .bib file for:

pandoc-citeproc: reference Peer2017 not found
pandoc-citeproc: reference Pierson2015 not found
pandoc-citeproc: reference Tseng2005 not found

cc: @drisso @kstreet13

@diyadas
Copy link
Collaborator

diyadas commented Jul 18, 2018

Will do! Have small formatting things I will also address. Thanks Marcel!

@LiNk-NY LiNk-NY added looks OK and removed problems Something isn't working labels Jul 18, 2018
@LiNk-NY LiNk-NY moved this from In progress to Done in Complete the Workshops Jul 18, 2018
@LiNk-NY LiNk-NY moved this from Done to In progress in Complete the Workshops Jul 18, 2018
lwaldron added a commit that referenced this issue Jul 22, 2018
@diyadas
Copy link
Collaborator

diyadas commented Jul 25, 2018

I did fix the citation issue locally - but I'm unable to push commits. Any chance that someone could check the permissions I have? So sorry for the last-minute change.

@seandavi
Copy link
Collaborator

@diyadas, could you make a pull request with just that change? We have disabled commits on the repo for everyone, as the workflows are "live" now. Sorry for the inconvenience.

@diyadas
Copy link
Collaborator

diyadas commented Jul 25, 2018

PR submitted, sorry if you got a lot of notifications as I had an interesting time with GitHub.

seandavi added a commit that referenced this issue Jul 25, 2018
adding missing citations (closes #22) and minor formatting
Complete the Workshops automation moved this from In progress to Done Jul 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Development

No branches or pull requests

8 participants