New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BgeeCall package #1002
Comments
Hi @jwollbrett Thanks for submitting your package. We are taking a quick The DESCRIPTION file for this package is:
Add SSH keys to your GitHub account. SSH keys |
A reviewer has been assigned to your package. Learn what to expect IMPORTANT: Please read the instructions for setting |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on Linux, Mac, and Windows. On one or more platforms, the build results were: "skipped, ERROR". Please see the build report for more details. |
Hi @jwollbrett , Before we do a package review it's important that your package build status is clean on the Single Package builder i.e no WARNINGS, NOTE, ERROR messages. Please fix them before we are able to continue with a review.
Best, Nitesh |
Hi @jwollbrett You have 2 weeks from today to get back to me regarding improving and getting your package to a reviewable state (i.e no BUILD , CHECK, INSTALL) errors on the build machine. After going through your package briefly, it has multiple issues in the vignette, please fix them all. The package needs to build on R > 3.6 and BiocManager - version 3.9.
Even after i've updated the versions as needed the vignette still errors out,
Please make sure your package is in a runnable state before you submit it for a review. We can close the issue if it takes longer than 2 weeks, and reopen when you are able to actively develop. Best, Nitesh |
Hello Nitesh,
I am currently on holiday and will be back the 11th of march. I will solve
this build/check problem before the middle of march.
Sorry.
Julien
Le ven. 22 févr. 2019 à 05:30, Nitesh Turaga <notifications@github.com> a
écrit :
… Hi @jwollbrett <https://github.com/jwollbrett>
You have 2 weeks from today to get back to me regarding improving and
getting your package to a reviewable state (i.e no BUILD , CHECK, INSTALL)
errors on the build machine.
We can close the issue if it takes longer, and reopen when you are able to
actively develop.
Best,
Nitesh
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1002 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFlVKlylI2FkCD7OFkX-IN3zENfQ2vCsks5vPsm7gaJpZM4axDQQ>
.
|
Hi @jwollbrett , That is fine. I'll close the issue and you can reopen it once you are back. Have a good holiday. Nitesh |
Hi @nturaga , I made some modifications. The package is now building |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on Linux, Mac, and Windows. On one or more platforms, the build results were: "skipped, ERROR". Please see the build report for more details. |
Received a valid push; starting a build. Commits are: 855507a version bump |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on Linux, Mac, and Windows. On one or more platforms, the build results were: "skipped, ERROR". Please see the build report for more details. |
Received a valid push; starting a build. Commits are: bbac2a8 modify minimum R version to be compatible with Ann... |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on Linux, Mac, and Windows. On one or more platforms, the build results were: "skipped, ERROR". Please see the build report for more details. |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on Linux, Mac, and Windows. On one or more platforms, the build results were: "skipped, ERROR". Please see the build report for more details. |
Received a valid push; starting a build. Commits are: 63051dc do not open pdf file |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on Linux, Mac, and Windows. On one or more platforms, the build results were: "skipped, ERROR". Please see the build report for more details. |
Hi @nturaga , I have an issue with my package. dyld: Library not loaded: @rpath/libz.1.dylib I am not able to understand where the problem comes from as I never saw this message on my computer. Could you please have a look and confirm that the problem does not come from your devel server? Thank you |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on Linux, Mac, and Windows. Congratulations! The package built without errors or warnings Please see the build report for more details. |
Hello, First of all, thank you for your clear answer. I added @return with a short description to all functions. I still have 6 NOTES remaining. The overall size of the package is 9Mb. The size of the extdata folder is 8.6Mb I will be available the full week and will be reactive to any suggestion of modification (I know you are busy with the new release) |
Hello @nturaga , |
ReviewDESCRIPTION
http://bioconductor.org/developers/package-guidelines/ NAMESPACE
R
NEWS
vignettes
|
Just as additional information, your package is pretty good now, and with a few minor modifications which were suggested in the review you can make it to the next release. |
Hello @nturaga , Thank you for your review. |
Received a valid push; starting a build. Commits are: 0b7f19e generate new output file summaryzing S4 slots valu... |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on Linux, Mac, and Windows. On one or more platforms, the build results were: "WARNINGS". Please see the build report for more details. |
Received a valid push; starting a build. Commits are: 4c93e78 bump version |
Hello @nturaga , I did some modifications taking into account the comments of your review.
Done
I created getters/setters for slots of BgeeMetadata and UserMetadata classes that can be used by user.
Thank you. I totally forgot to reactivate these 3 lines of code.
The package already tested that kallisto can be downloaded.
I was not aware of the differences between
Done
Done
Done |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on Linux, Mac, and Windows. On one or more platforms, the build results were: "WARNINGS". Please see the build report for more details. |
Hi @jwollbrett You are really close to getting your package accepted. Thank you for the helpful commit messages so I can easily review your package. I need you to fix the WARNING messages though,
Best, Nitesh |
Received a valid push; starting a build. Commits are: 38ba880 replace T/F by TRUE/FALSE |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on Linux, Mac, and Windows. Congratulations! The package built without errors or warnings Please see the build report for more details. |
Hello @nturaga , Sorry for this warning message. Everything build/check well now. |
Your package has been accepted. It will be added to the Thank you for contributing to Bioconductor! |
The master branch of your GitHub repository has been added to Bioconductor's git repository. To use the git.bioconductor.org repository, we need an 'ssh' key to associate with your github user name. If your GitHub account already has ssh public keys (https://github.com/jwollbrett.keys is not empty), then no further steps are required. Otherwise, do the following: See further instructions at https://bioconductor.org/developers/how-to/git/ for working with this repository. See especially https://bioconductor.org/developers/how-to/git/new-package-workflow/ to keep your GitHub and Bioconductor repositories in sync. Your package will be included in the next nigthly 'devel' build (check-out from git at about 6 pm Eastern; build completion around 2pm Eastern the next day) at https://bioconductor.org/checkResults/ (Builds sometimes fail, so ensure that the date stamps on the main landing page are consistent with the addition of your package). Once the package builds successfully, you package will be available for download in the 'Devel' version of Bioconductor using https://bioconductor.org/packages/BgeeCall If you have any questions, please contact the bioc-devel mailing list (https://stat.ethz.ch/mailman/listinfo/bioc-devel); this issue will not be monitored further. |
Update the following URL to point to the GitHub repository of
the package you wish to submit to Bioconductor
Confirm the following by editing each check box to '[x]'
I understand that by submitting my package to Bioconductor,
the package source and all review commentary are visible to the
general public.
I have read the Bioconductor Package Submission
instructions. My package is consistent with the Bioconductor
Package Guidelines.
I understand that a minimum requirement for package acceptance
is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS.
Passing these checks does not result in automatic acceptance. The
package will then undergo a formal review and recommendations for
acceptance regarding other Bioconductor standards will be addressed.
My package addresses statistical or bioinformatic issues related
to the analysis and comprehension of high throughput genomic data.
I am committed to the long-term maintenance of my package. This
includes monitoring the support site for issues that users may
have, subscribing to the bioc-devel mailing list to stay aware
of developments in the Bioconductor community, responding promptly
to requests for updates from the Core team in response to changes in
R or underlying software.
I am familiar with the essential aspects of Bioconductor software
management, including:
months, for bug fixes.
(optionally via GitHub).
For help with submitting your package, please subscribe and post questions
to the bioc-devel mailing list.
The text was updated successfully, but these errors were encountered: