-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multicrispr #1486
Comments
Thanks for submitting your package. We are taking a quick The DESCRIPTION file for this package is:
Add SSH keys to your GitHub account. SSH keys |
A reviewer has been assigned to your package. Learn what to expect IMPORTANT: Please read the instructions for setting |
As preliminary comments
|
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on Linux, Mac, and Windows. On one or more platforms, the build results were: "skipped, ERROR". Please see the build report for more details. |
By and large, basilisk should be able to handle the Python dependencies that I can see (2.7, azimuth, scikit-learn). The main issues occur on Windows, as they typically do. The success of installation of Python 2.7 on Windows is unpredictable, and installation of Python packages via |
Thankyou Martin & Aaron, |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on Linux, Mac, and Windows. On one or more platforms, the build results were: "skipped, ERROR". Please see the build report for more details. |
Received a valid push; starting a build. Commits are: 0d5f08c Update vignette |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on Linux, Mac, and Windows. On one or more platforms, the build results were: "skipped, ERROR". Please see the build report for more details. |
I followed your recommendations and:
Regarding the failure to build: this is puzzling to me. I can successfully build it in a win R-devel as well as a linux R-devel environment, without getting the errors of the BioC machines. Regarding basilisk: thank you for letting me know - looks interesting! That should be unrelated to the current issue of non-building, however. I have taken care in the (current) vignette to not run the python code (it's anyways only an optional last step in the whole gRNA design process). So I would prefer to first get the current vignette and package building. Thank you for your feedback! Aditya |
Since the vignette is failing, I installed the package
(using R 4.0.0 and BiocManager::install(version = "devel") I noticed that the git repository contains 'build products', i.e., the file vignettes/designing_grna_libraries.R. This file should not be present, because it will be created when the package is built. Nonetheless, I then ran 'Stangle' on the vignette to get the R code
This gave me an up-to-date version of designing_grna_libraries.R. So I started R and sourced that file
digging a little more
a little more digging after
and the next time round
which is looking kind of strange -- column is advertised as
and there's no
This seems very funky. So I confirmed that
returns TRUE, turned off debugging
and checked whether the examples on the
They did run successfully. A first guess is that SRF.bed is malformed. Other than that, I'm at a loss, and call on @lawremi or perhaps @hpages for advice... The simple reproducible example is, in a new R session,
|
Thankyou @mtmorgan! I can reproduce the error with the installed data file on rocker-devel:
Interestingly enough, the source data file does not give any issues:
What could be happening? Aditya |
Oh, this seems to be a git-lfs issue.
When I vim the source file, I get:
So I guess I should remove these files from git LFS tracking - will do and then push |
Yes, the build system is just going to If these are large files then probably you should either (a) identify a (much) more modest subset for demonstrating your software or (b) make the files available via ExperimentHub as a package. |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on Linux, Mac, and Windows. On one or more platforms, the build results were: "skipped, ERROR". Please see the build report for more details. |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on Linux, Mac, and Windows. On one or more platforms, the build results were: "skipped, ERROR". Please see the build report for more details. |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on Linux, Mac, and Windows. On one or more platforms, the build results were: "TIMEOUT, WARNINGS". Please see the build report for more details. |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on Linux, Mac, and Windows. On one or more platforms, the build results were: "skipped, ERROR". Please see the build report for more details. |
Received a valid push; starting a build. Commits are: 808d04a Re-roxygenize |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on Linux, Mac, and Windows. On one or more platforms, the build results were: "WARNINGS". Please see the build report for more details. |
Received a valid push; starting a build. Commits are: fb5063a AnnotationHub: Imports -> Suggests |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on Linux, Mac, and Windows. Congratulations! The package built without errors or warnings Please see the build report for more details. |
ReviewR CMD build
R CMD INSTALL
DESCRIPTION
NAMESPACE
NEWS
R
vignette
man
extdata
|
Hi Nitesh, thank you for your nice feedback :-), which I followed up on: R
extdata
Okay then, let me push my updates |
Received a valid push; starting a build. Commits are: ffa1738 Bump version |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on Linux, Mac, and Windows. Congratulations! The package built without errors or warnings Please see the build report for more details. |
Your package has been accepted. It will be added to the Thank you for contributing to Bioconductor! |
The master branch of your GitHub repository has been added to Bioconductor's git repository. To use the git.bioconductor.org repository, we need an 'ssh' key to associate with your github user name. If your GitHub account already has ssh public keys (https://github.com/bhagwataditya.keys is not empty), then no further steps are required. Otherwise, do the following: See further instructions at https://bioconductor.org/developers/how-to/git/ for working with this repository. See especially https://bioconductor.org/developers/how-to/git/new-package-workflow/ to keep your GitHub and Bioconductor repositories in sync. Your package will be included in the next nigthly 'devel' build (check-out from git at about 6 pm Eastern; build completion around 2pm Eastern the next day) at https://bioconductor.org/checkResults/ (Builds sometimes fail, so ensure that the date stamps on the main landing page are consistent with the addition of your package). Once the package builds successfully, you package will be available for download in the 'Devel' version of Bioconductor using https://bioconductor.org/packages/multicrispr If you have any questions, please contact the bioc-devel mailing list (https://stat.ethz.ch/mailman/listinfo/bioc-devel); this issue will not be monitored further. |
Update the following URL to point to the GitHub repository of
the package you wish to submit to Bioconductor
Confirm the following by editing each check box to '[x]'
I understand that by submitting my package to Bioconductor,
the package source and all review commentary are visible to the
general public.
I have read the Bioconductor Package Submission
instructions. My package is consistent with the Bioconductor
Package Guidelines.
I understand that a minimum requirement for package acceptance
is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS.
Passing these checks does not result in automatic acceptance. The
package will then undergo a formal review and recommendations for
acceptance regarding other Bioconductor standards will be addressed.
My package addresses statistical or bioinformatic issues related
to the analysis and comprehension of high throughput genomic data.
I am committed to the long-term maintenance of my package. This
includes monitoring the support site for issues that users may
have, subscribing to the bioc-devel mailing list to stay aware
of developments in the Bioconductor community, responding promptly
to requests for updates from the Core team in response to changes in
R or underlying software.
I am familiar with the essential aspects of Bioconductor software
management, including:
months, for bug fixes.
(optionally via GitHub).
For help with submitting your package, please subscribe and post questions
to the bioc-devel mailing list.
The text was updated successfully, but these errors were encountered: