-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discordant R Package Try #2 #178
Comments
Hi @siskac Thanks for submitting your package. We are taking a quick The DESCRIPTION file for this package is:
|
Your package has been approved for building. Your package is IMPORTANT: Please read the instructions for setting |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on Linux, Mac, and Windows. On one or more platforms, the build results were: "ERROR". Please see the following build report for more details: http://bioconductor.org/spb_reports/discordant_buildreport_20161023171800.html |
Hi,
Please remove Discordant_vignette.pdf and discordant_0.99.0.tar.gz from the top level of the package. Once that's done I'll do a full review. Valerie |
Checking in. Are you planning to submit an updated version of the package? Valerie |
I’m so sorry, I keep getting hit with deadlines every time I make time to deal with this. I will try to get it done by the end of this week. Charlotte Siska
|
Hello Valerie, I’ve made the updates. I did check with Bioccheck, and the same errors are coming up. I registered to Bioconductor, fixed the man pages and pretty sure I registered my C code. Could you please look at it and tell me what to fix? Thanks. Charlotte Siska
|
All of the errors are exactly the same as the last build report? |
I see what I did wrong - I got confused where to register, and did it on the mailing list but not the support. Still getting errors about registering native routines, which I thought I did. I followed the instructions given in the link you sent. I had to take out the description of datatypes (REALSXP, INTSXP) because it was causing an error while compiling. Do you have any advice? Thanks,
|
No, without seeing the error I can't help. Please bump the version and commit to the master branch. The single package builder will produce another build and I'll see the remaining errors in that output. For an example of a package that uses C code and registers routines look at GenomicAlignments: Valerie |
I figured out how to register native routines. Thank you for the help. I just pushed the updated version onto github. Please let me know if you need anything else. Charlotte Siska
|
You need to bump the version in your master github branch. This is the trigger for the single package builder. Once that's done we should see a new build report. |
Can you please bump the version? |
I think I just bumped the version. I apologize, I’m new to this and I thought updating the version in the DESCRIPTION file did they trick. Please let me know if it works.
Charlotte Siska
… On Nov 29, 2016, at 7:32 AM, vobencha ***@***.***> wrote:
Can you please bump the version?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#178 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AI73aVDEs4GnSRz_4kHt9B9bmChw7_3zks5rDDdggaJpZM4KeMmx>.
|
so, I am really confused. I bumped the version, but a new build report was not created? I bumped it on git, was I supposed to do it on svn as well? Any insights would be appreciated.
Charlotte Siska
… On Nov 29, 2016, at 10:46 AM, Charlotte Siska ***@***.***> wrote:
I think I just bumped the version. I apologize, I’m new to this and I thought updating the version in the DESCRIPTION file did they trick. Please let me know if it works.
Charlotte Siska
> On Nov 29, 2016, at 7:32 AM, vobencha ***@***.*** ***@***.***>> wrote:
>
> Can you please bump the version?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub <#178 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AI73aVDEs4GnSRz_4kHt9B9bmChw7_3zks5rDDdggaJpZM4KeMmx>.
>
|
It should have been. I'll ask Lori for a forced build. |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on Linux, Mac, and Windows. On one or more platforms, the build results were: "WARNINGS, skipped, ERROR". Please see the following build report for more details: http://bioconductor.org/spb_reports/discordant_buildreport_20161208070300.html |
I searched the errors on the internet, and I found on the forum this error can happen at random. http://thread.gmane.org/gmane.science.biology.informatics.conductor.devel/9264 Should I do another build? Or is there something I can do to prevent this error in the future? |
You can ignore the MiKTeK errors for now. We see this warning on linux:
You need to remove the inst/doc directory and the build/ directory. Bump the version and resubmit. |
ok I just removed the directories and bumped the version but not seeing any build. is there another step that I am missing? Thanks.
… On Dec 8, 2016, at 2:44 PM, vobencha ***@***.***> wrote:
You can ignore the MiKTeK errors for now. We see this warning on linux:
creating vignettes ... OK
Warning: inst/doc files
Discordant_vignette.Rnw, Discordant_vignette.pdf
ignored as vignettes have been rebuilt.
You need to remove the inst/doc directory and the build/ directory. Bump the version and resubmit.
Valerie
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#178 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AI73aRaBUWT23bg0zIbVE28mwMlQHjMVks5rGHpFgaJpZM4KeMmx>.
|
Received a valid push; starting a build. Commits are: 5dd0e6e bumped version to 0.99.2 try 2 |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on Linux, Mac, and Windows. On one or more platforms, the build results were: "skipped, ERROR". Please see the following build report for more details: http://bioconductor.org/spb_reports/discordant_buildreport_20161209181329.html |
I'm able to reproduce this error on my linux system so it is real, not a problem with the builders:
|
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on Linux, Mac, and Windows. On one or more platforms, the build results were: "skipped, ERROR". Please see the following build report for more details: http://bioconductor.org/spb_reports/discordant_buildreport_20161211154214.html |
It seems with latest version 0.99.5 there are no errors in malbec2, but still getting errors about the vignette for tokay2 and oaxaca. Please let me know how I should proceed. |
Hi, We can ignore the MiKTeK errors on windows and mac for now. I've done the full review and below are some comments and suggestions.
Biocondcutor encourages interoperability between packages. If methods in your package support (as input) the base infrastructure classes it's easier for a user to apply your method to their data. Please have a look at the ExpressionSet, SummarizedExperiment or MultiAssayExperiment classes. http://www.bioconductor.org/packages/3.5/bioc/html/Biobase.html http://www.bioconductor.org/packages/3.5/bioc/html/SummarizedExperiment.html http://www.bioconductor.org/packages/3.5/bioc/html/MultiAssayExperiment.html One of those should be appropriate as inputs, e.g., please support one of these classes as the
Please add a \details section to these man pages: createVectors.Rd, discordantRun.Rd, fishersTrans.Rd and splitMADOutlier.Rd. Explain a bit about what they do and how they are unique to the package, e.g., a fisher transformation is
The \value section should describe the output object in general and then list specifics. Using split.MADOutlier() as an example, \value{ If I run the example at the bottom of the page I get a 'mat.filtered' variable. There is no guarantee the use will name this result 'mat.filtered' so it doesn't make sense to document that name in as output in \value. The actual output is a matirx:
With these dimnames (what do they mean?):
[[2]] I don't see an 'index' as part of the output so I'm not sure why it's documented in \value. This needs to be fixed in all function man pages not just split.MADOutlier().
On fisherTrans.Rd the 'rhoV' input is described as a integer or numeric list. It's not a list but a vector:
Please double check the object types you've listed for the inputs.
i) Please remove this from the vignette: \section{Required packages} When the DESCRIPTION and NAMESPACE are properly specificed you don't need to tell the use what packages discordant depends on. When biocLite("discordant") is called, all depedencies are automatically loaded. ii) You load MASS in the fisherTrans() example for mvrnorm(). This is fine but if you expect the user to need this and other functions from MASS you could put it in 'Depends' in DESCRIPTION. I don't think the MASS package is heavy to load and it may be a good idea to make all those functions available to the user by just loading discordant.
None of your code chunks are evaluated. Instead they are wrapped in \begin{verbatim}, \end{verbatim}. Please remove the verbatim statements and evaluate the code. We recommend the use of the BiocStyle pacakge: http://www.bioconductor.org/packages/3.5/bioc/html/BiocStyle.html There are vignettes on the package landing page that show how to create a pdf or html vignette.
I would recommend adding some checks in your code to confirm the inputs are what you expect. For example, if I give a 'groups' vector of length 2 to createVectors() no warning or error is thrown and yet the NAs are probably not what was intended. If it's expected that 'groups' is recycled that should be in the documentation.
Let me know if you have questions. Valerie |
We only start builds when the
to
If you did not intend to start a build, you don't need to |
1 similar comment
We only start builds when the
to
If you did not intend to start a build, you don't need to |
Checking in. I'd like to finalize the package next week if at all possible. |
I am just about done with edits you gave, but I am having issues with biocstyle in the vignette. Could you direct me to a r package that has a vignette I could reference? Thanks.
…Sent from my iPhone
On Dec 29, 2016, at 7:07 AM, vobencha ***@***.***> wrote:
Checking in. I'd like to finalize the package next week if at all possible.
Let me know if you have questions.
Valerie
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Both GenomicTuples and genoset use BiocStyle, http://www.bioconductor.org/packages/3.5/bioc/html/GenomicTuples.html |
Received a valid push; starting a build. Commits are: 7b9a67c Merge branch 'release-0.99.5' into develop |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on Linux, Mac, and Windows. On one or more platforms, the build results were: "skipped, ERROR". Please see the following build report for more details: http://bioconductor.org/spb_reports/discordant_buildreport_20170102184627.html |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on Linux, Mac, and Windows. On one or more platforms, the build results were: "skipped, ERROR, WARNINGS". Please see the following build report for more details: http://bioconductor.org/spb_reports/discordant_buildreport_20170102193048.html |
Hey, could we please get this evaluated by the end of this week? Thanks!
…Sent from my iPhone
On Jan 2, 2017, at 5:30 PM, bioc-issue-bot ***@***.***> wrote:
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "skipped, ERROR, WARNINGS".
This may mean there is a problem with the package that you need to fix.
Or it may mean that there is a problem with the build system itself.
Please see the following build report for more details:
http://bioconductor.org/spb_reports/discordant_buildreport_20170102193048.html
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Sorry for the delay. I think all of the SPB issues have been fixed and it would be best to get a clean build before approval. @lshep can you please kick off a new SPB for this issue? |
Rerunning now, there should be a new build report posted shortly. |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on Linux, Mac, and Windows. On one or more platforms, the build results were: "WARNINGS". Please see the following build report for more details: http://bioconductor.org/spb_reports/discordant_buildreport_20170109115739.html |
Received a valid push; starting a build. Commits are: 0a8dd9f changed R dependency |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on Linux, Mac, and Windows. Congratulations! The package built without errors or warnings Please see the following build report for more details: http://bioconductor.org/spb_reports/discordant_buildreport_20170109205542.html |
How soon will the R package be on the website? We have a paper that was just accepted on the extensions and would like to include the link to discordant on bioconductor. Thanks!
…Sent from my iPhone
On Jan 9, 2017, at 6:55 PM, bioc-issue-bot ***@***.***> wrote:
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings
on all platforms.
Please see the following build report for more details:
http://bioconductor.org/spb_reports/discordant_buildreport_20170109205542.html
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
It will probably take a week to post on the web site. In the next few days you'll get an email with svn credentials and instructions. The package will only be available in devel until the next release in April 2017 after which it's available in both. For your publication you can use this link which will take you to the release page unless the package is only available in devel: Valerie |
Update the following URL to point to the GitHub repository of
the package you wish to submit to Bioconductor
Confirm the following by editing each check box to '[x]'
the package source and all review commentary are visible to the
general public.
instructions. My package is consistent with the Bioconductor
Package Guidelines.
is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS.
Passing these checks does not result in automatic acceptance. The
package will then undergo a formal review and recommendations for
acceptance regarding other Bioconductor standards will be addressed.
to the analysis and comprehension of high throughput genomic data.
includes monitoring the support site for issues that users may
have, subscribing to the bioc-devel mailing list to stay aware
of developments in the Bioconductor community, responding promptly
to requests for updates from the Core team in response to changes in
R or underlying software.
I am familiar with the essential aspects of Bioconductor software
management, including:
months, for bug fixes.
(optionally via GitHub).
For help with submitting your package, please subscribe and post questions
to the bioc-devel mailing list.
The text was updated successfully, but these errors were encountered: