-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NanoStringNCTools #1815
Comments
Hi @rvitancol Thanks for submitting your package. We are taking a quick The DESCRIPTION file for this package is:
|
A reviewer has been assigned to your package. Learn what to expect IMPORTANT: Please read this documentation for setting Bioconductor utilized your github ssh-keys for git.bioconductor.org |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on Linux, Mac, and Windows. On one or more platforms, the build results were: "ERROR". Please see the build report for more details. This link will be active Remember: if you submitted your package after July 7th, 2020, |
AdditionalPackage: https://github.com/Nanostring-Biostats/GeomxTools |
Hi @rvitancol, |
Additional Package has been approved for building. IMPORTANT: Please read this documentation for setting |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on Linux, Mac, and Windows. On one or more platforms, the build results were: "ERROR". Please see the build report for more details. This link will be active Remember: if you submitted your package after July 7th, 2020, |
Received a valid push on git.bioconductor.org; starting a build for commit id: 7e152ffe7afda60d1f72a202391225266a8f724f |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on Linux, Mac, and Windows. On one or more platforms, the build results were: "ERROR". Please see the build report for more details. This link will be active Remember: if you submitted your package after July 7th, 2020, |
Received a valid push on git.bioconductor.org; starting a build for commit id: ff1d1eb312c96d092154f4d3a713a86c4e5de7b6 |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on Linux, Mac, and Windows. On one or more platforms, the build results were: "WARNINGS". Please see the build report for more details. This link will be active Remember: if you submitted your package after July 7th, 2020, |
Received a valid push on git.bioconductor.org; starting a build for commit id: f4d30c6cb8fb1539635bd12e417837d4b7fa6706 |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on Linux, Mac, and Windows. On one or more platforms, the build results were: "WARNINGS". Please see the build report for more details. This link will be active Remember: if you submitted your package after July 7th, 2020, |
Received a valid push on git.bioconductor.org; starting a build for commit id: 982d3bc731fbefd4ccd559af0a71a8322404d2da |
Received a valid push on git.bioconductor.org; starting a build for commit id: 7d83cdedda9150ecaedc746042082b552aac7566 |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on Linux, Mac, and Windows. On one or more platforms, the build results were: "WARNINGS, ERROR". Please see the build report for more details. This link will be active Remember: if you submitted your package after July 7th, 2020, |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on Linux, Mac, and Windows. On one or more platforms, the build results were: "WARNINGS". Please see the build report for more details. This link will be active Remember: if you submitted your package after July 7th, 2020, |
Hi @nturaga, can we ask for the check.log from the R CMD check for the Windows build for GeomxTools? The error in the build report does not give us a clue where the error happens and this does not appear in our local R CMD CHECK.
|
Received a valid push on git.bioconductor.org; starting a build for commit id: d914164ce3c745bf8a58d20e686b04d2dd0da0f7 |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on Linux, Mac, and Windows. On one or more platforms, the build results were: "WARNINGS". Please see the build report for more details. This link will be active Remember: if you submitted your package after July 7th, 2020, |
Notes on warnings and error related to R version: Tested these packages on the latest version of R, but we also require that they work on an older version (Depends: R (>= 3.6) for a report tool we use internally. The packages have undergone internal V&V as part of the report that we use internally. |
Received a valid push on git.bioconductor.org; starting a build for commit id: 3512b5565d3aaa97cfc8566b96c444dd92ee7d8b |
Received a valid push on git.bioconductor.org; starting a build for commit id: 82d41fd6e8405c92fac6d1c52e10e86437f88c16 |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on Linux, Mac, and Windows. On one or more platforms, the build results were: "ERROR". Please see the build report for more details. This link will be active Remember: if you submitted your package after July 7th, 2020, |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on Linux, Mac, and Windows. On one or more platforms, the build results were: "ERROR, WARNINGS". Please see the build report for more details. This link will be active Remember: if you submitted your package after July 7th, 2020, |
Yes, you can ignore these. |
NanoStringNCTools reviewR CMD buildok R CMD checkok DESCRIPTIONok NAMESPACE
Build report warnings
R
vignette
|
Hi @nturaga , @rvitancol , The error on Windows seems to have occurred during H. |
Received a valid push on git.bioconductor.org; starting a build for commit id: 9c451811389d10403d86bf1494e4d45a6ee8cdd4 |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on Linux, Mac, and Windows. On one or more platforms, the build results were: "ERROR". Please see the build report for more details. This link will be active Remember: if you submitted your package after July 7th, 2020, |
Received a valid push on git.bioconductor.org; starting a build for commit id: c6bd6f9dc9aa6ed79805e756f30edbcc20b306fa |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on Linux, Mac, and Windows. On one or more platforms, the build results were: "ERROR, WARNINGS, skipped". Please see the build report for more details. This link will be active Remember: if you submitted your package after July 7th, 2020, |
@nturaga I believe our packages are ready to go. |
Received a valid push on git.bioconductor.org; starting a build for commit id: d2eb6cc4bba5258a5f8ccd73fb4d025ad7893b9d |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on Linux, Mac, and Windows. On one or more platforms, the build results were: "ERROR, WARNINGS, skipped". Please see the build report for more details. This link will be active Remember: if you submitted your package after July 7th, 2020, |
Hi @NicoleEO , |
@nturaga why do you say there is no build tarball produced for Linux? The package only has a check warning for Linux. The package didn't build for Mac and as we explained multiple times this is likely do to Mac binaries not being produced on CRAN yet for Rdevel and should be ignored. This is confirmed by searching for the package not available https://cran.r-project.org/web/packages/ggiraph/index.html . Please ignore the Mac error and accept based on the other two build reports. |
@nturaga the last sapply is used to extend sapply to our class for users. Would it be possible to pass this one by as it is purposely kept as sapply to allow the user flexibility with unknown data types they may apply on? |
That's fine. We suggest |
Your package has been accepted. It will be added to the Thank you for contributing to Bioconductor! |
@nturaga thanks for accepting. Does this also automatically apply to our additional package as well? |
Yes.
…On Fri, Jan 22, 2021 at 8:23 AM Nicole Ortogero ***@***.***> wrote:
@nturaga <https://github.com/nturaga> thanks for accepting. Does this
also automatically apply to our additional package as well?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1815 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAU6QSYEKXNMIS6L4UV7EI3S3G7BDANCNFSM4U5I3FMQ>
.
|
The master branch of your GitHub repository has been added to Bioconductor's git repository. To use the git.bioconductor.org repository, we need an 'ssh' key to associate with your github user name. If your GitHub account already has ssh public keys (https://github.com/rvitancol.keys is not empty), then no further steps are required. Otherwise, do the following: See further instructions at https://bioconductor.org/developers/how-to/git/ for working with this repository. See especially https://bioconductor.org/developers/how-to/git/new-package-workflow/ to keep your GitHub and Bioconductor repositories in sync. Your package will be included in the next nigthly 'devel' build (check-out from git at about 6 pm Eastern; build completion around 2pm Eastern the next day) at https://bioconductor.org/checkResults/ (Builds sometimes fail, so ensure that the date stamps on the main landing page are consistent with the addition of your package). Once the package builds successfully, you package will be available for download in the 'Devel' version of Bioconductor using https://bioconductor.org/packages/NanoStringNCTools If you have any questions, please contact the bioc-devel mailing list (https://stat.ethz.ch/mailman/listinfo/bioc-devel); this issue will not be monitored further. |
The master branch of your GitHub repository has been added to Bioconductor's git repository. To use the git.bioconductor.org repository, we need an 'ssh' key to associate with your github user name. If your GitHub account already has ssh public keys (https://github.com/rvitancol.keys is not empty), then no further steps are required. Otherwise, do the following: See further instructions at https://bioconductor.org/developers/how-to/git/ for working with this repository. See especially https://bioconductor.org/developers/how-to/git/new-package-workflow/ to keep your GitHub and Bioconductor repositories in sync. Your package will be included in the next nigthly 'devel' build (check-out from git at about 6 pm Eastern; build completion around 2pm Eastern the next day) at https://bioconductor.org/checkResults/ (Builds sometimes fail, so ensure that the date stamps on the main landing page are consistent with the addition of your package). Once the package builds successfully, you package will be available for download in the 'Devel' version of Bioconductor using https://bioconductor.org/packages/GeomxTools If you have any questions, please contact the bioc-devel mailing list (https://stat.ethz.ch/mailman/listinfo/bioc-devel); this issue will not be monitored further. |
Update the following URL to point to the GitHub repository of
the package you wish to submit to Bioconductor
Confirm the following by editing each check box to '[x]'
I understand that by submitting my package to Bioconductor,
the package source and all review commentary are visible to the
general public.
I have read the Bioconductor Package Submission
instructions. My package is consistent with the Bioconductor
Package Guidelines.
I understand that a minimum requirement for package acceptance
is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS.
Passing these checks does not result in automatic acceptance. The
package will then undergo a formal review and recommendations for
acceptance regarding other Bioconductor standards will be addressed.
My package addresses statistical or bioinformatic issues related
to the analysis and comprehension of high throughput genomic data.
I am committed to the long-term maintenance of my package. This
includes monitoring the support site for issues that users may
have, subscribing to the bioc-devel mailing list to stay aware
of developments in the Bioconductor community, responding promptly
to requests for updates from the Core team in response to changes in
R or underlying software.
I am familiar with the Bioconductor code of conduct and
agree to abide by it.
I am familiar with the essential aspects of Bioconductor software
management, including:
months, for bug fixes.
(optionally via GitHub).
For help with submitting your package, please subscribe and post questions
to the bioc-devel mailing list.
The text was updated successfully, but these errors were encountered: