New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ngsReports Submission #985
Comments
Hi @steveped Thanks for submitting your package. We are taking a quick The DESCRIPTION file for this package is:
Add SSH keys to your GitHub account. SSH keys |
A reviewer has been assigned to your package. Learn what to expect IMPORTANT: Please read the instructions for setting |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on Linux, Mac, and Windows. On one or more platforms, the build results were: "skipped, ERROR". Please see the build report for more details. |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on Linux, Mac, and Windows. On one or more platforms, the build results were: "skipped, ERROR". Please see the build report for more details. |
Received a valid push; starting a build. Commits are: f9105f2 Removed spurious import |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on Linux, Mac, and Windows. On one or more platforms, the build results were: "skipped, ERROR". Please see the build report for more details. |
Received a valid push; starting a build. Commits are: 33575e9 Dammit. Fixed NAMESPACE this time |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on Linux, Mac, and Windows. On one or more platforms, the build results were: "skipped, ERROR". Please see the build report for more details. |
Received a valid push; starting a build. Commits are: 52667e8 OK. Got it this time. It was in the Depends field |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on Linux, Mac, and Windows. On one or more platforms, the build results were: "ERROR". Please see the build report for more details. |
Received a valid push; starting a build. Commits are: d4d117b - Changed suffix of example files from *.log to *.... |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on Linux, Mac, and Windows. Congratulations! The package built without errors or warnings Please see the build report for more details. |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on Linux, Mac, and Windows. On one or more platforms, the build results were: "ERROR, WARNINGS". Please see the build report for more details. |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on Linux, Mac, and Windows. On one or more platforms, the build results were: "ERROR, WARNINGS". Please see the build report for more details. |
Hi @LiNk-NY ,
|
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on Linux, Mac, and Windows. On one or more platforms, the build results were: "TIMEOUT, ERROR". Please see the build report for more details. |
Hi again @LiNk-NY. |
celaya2 - CRAN will eventually provide the binaries for this R version - you can ignore for now and we will review based on the other two platforms |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on Linux, Mac, and Windows. On one or more platforms, the build results were: "ERROR". Please see the build report for more details. |
Thanks @lshep . Much appreciated & it looks like that glitch was the problem. |
Hi Steve, @steveped Apologies for the delay. Thanks for bearing with our SPB / CRAN troubles. Best, |
Thanks Marcel @LiNk-NY . I fear this is a surprisingly big package to look through too, so my apologies for adding another pile to your workload |
Hi Steve, @steveped Reply in the issue if you have any questions. Best, ngsReports #985DESCRIPTION
NAMESPACE
vignettes
R
|
Hi Marcel, Thanks for all of those comments and there's lots for us to work on there and we'll get onto it. There were a few things we were unclear on though. If possible, could you try to help us understand these comments?
I'm a
Do you mean from
One additional question I had which may clear up a few other questions you had too, is that much of the design was based around the shiny app which we removed because we couldn't figure out how to include it in a Bioc-type manner. We've just found https://github.com/jdgagnon/plotGrouper which gave us a good solution to this. Would including this app in Thanks again and we'll get going on all the changes that we do understand in the meantime. Cheers, Steve |
Yes, it should be a standalone constructor function that performs the necessary input checks
Yes, with S4 classes, you can create a
That is correct, you don't want to step on other classes' toes. They should have a set of defined methods within their package and you should only create and modify methods within yours. The point of Bioconductor is to re-use other classes where appropriate such as
Consider input other than
I would encourage you to keep the functionality in a separate package. It is best to have a cohesive package that works on a single / central representation. You can also consider submitting the shiny package to Bioconductor as well. Best, |
Hi Steve, @steveped Best regards, |
Hi Marcel @LiNk-NY , Nearly there. Your comments were asking considerable rewrite of the package and we've still got 3 points on your list left to address. Hoping to have them done by the end of the week. Latest commit is at: https://github.com/UofABioinformaticsHub/ngsReports/tree/dev. When does the next release of BioC close? I'm desperately trying to get it done by then. All the best, Steve |
Hi Steve, @steveped Here is the release schedule http://bioconductor.org/developers/release-schedule/. Best, |
Received a valid push; starting a build. Commits are: 48df2fb Added Marcel's comments in BiocTODO.md |
Hi Marcel @LiNk-NY . There's a push being tested & built now. I thought I'd post your comments & my thoughts as well. Hope they make sense. See below. Cheers, Steve DESCRIPTION
NAMESPACE
Vignettes
R
|
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on Linux, Mac, and Windows. On one or more platforms, the build results were: "WARNINGS". Please see the build report for more details. |
Received a valid push; starting a build. Commits are: 24c3157 Removed Maintainer field from DESCRIPTION |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on Linux, Mac, and Windows. On one or more platforms, the build results were: "WARNINGS". Please see the build report for more details. |
Hi Steve, @steveped Best regards, |
Your package has been accepted. It will be added to the Thank you for contributing to Bioconductor! |
Thanks Marcel . Great news! Steve |
The master branch of your GitHub repository has been added to Bioconductor's git repository. To use the git.bioconductor.org repository, we need an 'ssh' key to associate with your github user name. If your GitHub account already has ssh public keys (https://github.com/steveped.keys is not empty), then no further steps are required. Otherwise, do the following: See further instructions at https://bioconductor.org/developers/how-to/git/ for working with this repository. See especially https://bioconductor.org/developers/how-to/git/new-package-workflow/ to keep your GitHub and Bioconductor repositories in sync. Your package will be included in the next nigthly 'devel' build (check-out from git at about 6 pm Eastern; build completion around 2pm Eastern the next day) at https://bioconductor.org/checkResults/ (Builds sometimes fail, so ensure that the date stamps on the main landing page are consistent with the addition of your package). Once the package builds successfully, you package will be available for download in the 'Devel' version of Bioconductor using https://bioconductor.org/packages/ngsReports If you have any questions, please contact the bioc-devel mailing list (https://stat.ethz.ch/mailman/listinfo/bioc-devel); this issue will not be monitored further. |
Update the following URL to point to the GitHub repository of
the package you wish to submit to Bioconductor
Confirm the following by editing each check box to '[x]'
I understand that by submitting my package to Bioconductor,
the package source and all review commentary are visible to the
general public.
I have read the Bioconductor Package Submission
instructions. My package is consistent with the Bioconductor
Package Guidelines.
I understand that a minimum requirement for package acceptance
is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS.
Passing these checks does not result in automatic acceptance. The
package will then undergo a formal review and recommendations for
acceptance regarding other Bioconductor standards will be addressed.
My package addresses statistical or bioinformatic issues related
to the analysis and comprehension of high throughput genomic data.
I am committed to the long-term maintenance of my package. This
includes monitoring the support site for issues that users may
have, subscribing to the bioc-devel mailing list to stay aware
of developments in the Bioconductor community, responding promptly
to requests for updates from the Core team in response to changes in
R or underlying software.
I am familiar with the essential aspects of Bioconductor software
management, including:
months, for bug fixes.
(optionally via GitHub).
For help with submitting your package, please subscribe and post questions
to the bioc-devel mailing list.
The text was updated successfully, but these errors were encountered: